-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use correct rendered frames timestamp #3531
Conversation
SentryAppStartMeasurement is only plublic for hybrid SDKs since #2458. Therefore, we can remove the deprecated init method.
When performanceV2 is enabled, the app start ends when the app draws the first frame instead of when it receives the UIWindowDidBecomeVisibleNotification.
Use the timestamp of the DisplayLink wrapper when a new frame is reported for TTID/TTFD and the app start.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3531 +/- ##
=============================================
- Coverage 89.284% 89.237% -0.048%
=============================================
Files 528 528
Lines 57655 57634 -21
Branches 20657 20649 -8
=============================================
- Hits 51477 51431 -46
- Misses 5155 5287 +132
+ Partials 1023 916 -107
... and 44 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3437454 | 1225.64 ms | 1234.31 ms | 8.67 ms |
25bcc50 | 1233.47 ms | 1234.27 ms | 0.80 ms |
7bb0873 | 1360.94 ms | 1362.24 ms | 1.30 ms |
e7b566f | 1197.49 ms | 1229.46 ms | 31.97 ms |
7bc3c0d | 1222.86 ms | 1244.90 ms | 22.04 ms |
326b7eb | 1252.86 ms | 1259.56 ms | 6.70 ms |
c78683b | 1246.71 ms | 1258.70 ms | 11.99 ms |
5616e0a | 1224.12 ms | 1249.86 ms | 25.74 ms |
f715499 | 1234.26 ms | 1259.40 ms | 25.14 ms |
216bdf9 | 1193.69 ms | 1217.90 ms | 24.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3437454 | 22.85 KiB | 408.87 KiB | 386.02 KiB |
25bcc50 | 20.76 KiB | 427.22 KiB | 406.46 KiB |
7bb0873 | 22.85 KiB | 407.09 KiB | 384.24 KiB |
e7b566f | 22.85 KiB | 414.80 KiB | 391.95 KiB |
7bc3c0d | 20.76 KiB | 427.36 KiB | 406.59 KiB |
326b7eb | 20.76 KiB | 432.31 KiB | 411.55 KiB |
c78683b | 20.76 KiB | 435.24 KiB | 414.48 KiB |
5616e0a | 22.85 KiB | 407.44 KiB | 384.59 KiB |
f715499 | 20.76 KiB | 427.23 KiB | 406.47 KiB |
216bdf9 | 21.58 KiB | 418.13 KiB | 396.54 KiB |
Previous results on branch: fix/rendered-frame-timestamp
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5e7fb4 | 1215.28 ms | 1229.82 ms | 14.55 ms |
e669be6 | 1225.63 ms | 1252.06 ms | 26.43 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5e7fb4 | 21.58 KiB | 418.76 KiB | 397.17 KiB |
e669be6 | 21.58 KiB | 418.70 KiB | 397.12 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7b30ea0
to
47bde7f
Compare
📜 Description
Use the timestamp of the DisplayLink wrapper when a new frame is reported for TTID/TTFD and the app start. This PR is based on #3530.
💡 Motivation and Context
I noticed that the end timestamps of TTID and the app start initial frame render didn't match properly in #3530.
Previously
The duration of the app start and the TTID don't match.
Fixed version
Now they do.
💚 How did you test it?
Unit tests and simulator.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps