Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prewarmed App Start Tracing is stable #3536

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jan 4, 2024

📜 Description

Make the option enablePreWarmedAppStartTracing stable.

Docs PR getsentry/sentry-docs#8812.

💡 Motivation and Context

The option has been in beta for over a year. We didn't hear any complaints about the feature. Let's make it stable and fix problems if required. The plan is to turn this feature on by default in the next major #3535.

💚 How did you test it?

No complaints.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Make the option enablePreWarmedAppStartTracing stable.
Copy link

github-actions bot commented Jan 4, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f02fee0

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f74904f) 89.213% compared to head (f02fee0) 89.258%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3536       +/-   ##
=============================================
+ Coverage   89.213%   89.258%   +0.045%     
=============================================
  Files          528       528               
  Lines        57620     57638       +18     
  Branches     20637     20646        +9     
=============================================
+ Hits         51405     51447       +42     
- Misses        5185      5278       +93     
+ Partials      1030       913      -117     

see 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74904f...f02fee0. Read the comment docs.

Copy link

github-actions bot commented Jan 4, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.91 ms 1235.42 ms 19.50 ms
Size 21.58 KiB 418.70 KiB 397.12 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e681215 6240.94 ms 6254.36 ms 13.42 ms
4053ee9 1248.04 ms 1250.82 ms 2.78 ms
302ee8b 1194.02 ms 1223.34 ms 29.32 ms
25bcc50 1240.47 ms 1254.70 ms 14.23 ms
cce35c6 1228.88 ms 1241.14 ms 12.26 ms
7bb0873 1226.18 ms 1247.30 ms 21.12 ms
10ee2ce 1250.90 ms 1258.57 ms 7.67 ms
7bc3c0d 1212.35 ms 1228.94 ms 16.59 ms
f587451 1271.63 ms 1275.90 ms 4.27 ms
d61b939 1238.61 ms 1240.08 ms 1.47 ms

App size

Revision Plain With Sentry Diff
e681215 20.76 KiB 431.91 KiB 411.15 KiB
4053ee9 20.76 KiB 435.22 KiB 414.46 KiB
302ee8b 20.76 KiB 419.62 KiB 398.87 KiB
25bcc50 20.76 KiB 427.22 KiB 406.46 KiB
cce35c6 20.76 KiB 425.80 KiB 405.04 KiB
7bb0873 22.85 KiB 407.09 KiB 384.24 KiB
10ee2ce 20.76 KiB 427.77 KiB 407.00 KiB
7bc3c0d 20.76 KiB 427.35 KiB 406.59 KiB
f587451 20.76 KiB 435.25 KiB 414.49 KiB
d61b939 22.85 KiB 407.63 KiB 384.78 KiB

Previous results on branch: feat/prewarmed-app-start-tracing-ga

Startup times

Revision Plain With Sentry Diff
81d9906 1209.80 ms 1229.04 ms 19.24 ms

App size

Revision Plain With Sentry Diff
81d9906 21.58 KiB 418.70 KiB 397.12 KiB

@philipphofmann philipphofmann merged commit fa38a2b into main Jan 4, 2024
66 of 70 checks passed
@philipphofmann philipphofmann deleted the feat/prewarmed-app-start-tracing-ga branch January 4, 2024 13:03
philipphofmann added a commit that referenced this pull request Jan 10, 2024
Make the option enablePreWarmedAppStartTracing stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants