-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't override sentry-trace
and baggage
headers
#3540
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a6ac3d2 | 1219.00 ms | 1231.32 ms | 12.32 ms |
60dd0f5 | 1238.98 ms | 1254.48 ms | 15.50 ms |
e89dc54 | 1220.57 ms | 1233.45 ms | 12.88 ms |
d9fff0f | 1205.09 ms | 1247.40 ms | 42.31 ms |
734d507 | 1201.78 ms | 1213.96 ms | 12.18 ms |
98cca71 | 1230.43 ms | 1252.36 ms | 21.93 ms |
cd39d58 | 1203.87 ms | 1239.88 ms | 36.01 ms |
c6773e5 | 1222.48 ms | 1240.02 ms | 17.54 ms |
c319795 | 1205.12 ms | 1231.20 ms | 26.08 ms |
75ef4eb | 1237.30 ms | 1249.53 ms | 12.23 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a6ac3d2 | 20.76 KiB | 436.65 KiB | 415.89 KiB |
60dd0f5 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
e89dc54 | 22.85 KiB | 412.60 KiB | 389.75 KiB |
d9fff0f | 22.85 KiB | 401.65 KiB | 378.81 KiB |
734d507 | 22.85 KiB | 412.66 KiB | 389.81 KiB |
98cca71 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
cd39d58 | 20.76 KiB | 435.26 KiB | 414.50 KiB |
c6773e5 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
c319795 | 20.76 KiB | 431.99 KiB | 411.22 KiB |
75ef4eb | 22.85 KiB | 413.45 KiB | 390.60 KiB |
Previous results on branch: fix/trace-header
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
28a6968 | 1204.69 ms | 1220.02 ms | 15.33 ms |
6f034a1 | 1227.18 ms | 1241.96 ms | 14.77 ms |
8cd0d31 | 1201.35 ms | 1217.61 ms | 16.27 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
28a6968 | 21.58 KiB | 418.86 KiB | 397.28 KiB |
6f034a1 | 21.58 KiB | 418.86 KiB | 397.28 KiB |
8cd0d31 | 21.58 KiB | 418.86 KiB | 397.28 KiB |
…into fix/trace-header
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3540 +/- ##
=============================================
+ Coverage 89.213% 89.254% +0.040%
=============================================
Files 528 528
Lines 57620 57706 +86
Branches 20637 20678 +41
=============================================
+ Hits 51405 51505 +100
- Misses 5185 5287 +102
+ Partials 1030 914 -116
... and 53 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Don't override sentry-trace and baggage headers in a http request. Cross platform SDKs may set this headers and we're overriding it.
📜 Description
Don't override
sentry-trace
andbaggage
headers in a http request.Cross platform SDKs may set this headers and we're overriding it.
💡 Motivation and Context
Close #3490
💚 How did you test it?
Unit test
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps