Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use main thread for app hang screenshot and view hierarchy #3547

Merged
merged 10 commits into from
Feb 2, 2024

Merge branch 'main' into fix/screenshot-anr

78d91d8
Select commit
Loading
Failed to load commit list.
Merged

fix: Don't use main thread for app hang screenshot and view hierarchy #3547

Merge branch 'main' into fix/screenshot-anr
78d91d8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 1, 2024 in 0s

89.327% (+0.037%) compared to 1c96132

View this Pull Request on Codecov

89.327% (+0.037%) compared to 1c96132

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1c96132) 89.289% compared to head (78d91d8) 89.327%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3547       +/-   ##
=============================================
+ Coverage   89.289%   89.327%   +0.037%     
=============================================
  Files          529       529               
  Lines        57737     57979      +242     
  Branches     20412     20740      +328     
=============================================
+ Hits         51553     51791      +238     
  Misses        5276      5276               
- Partials       908       912        +4     
Files Coverage Δ
Sources/Sentry/SentryANRTrackingIntegration.m 95.918% <100.000%> (ø)
Sources/Sentry/SentryEvent.m 98.518% <100.000%> (+0.045%) ⬆️
Sources/Sentry/SentryScreenshotIntegration.m 91.836% <100.000%> (+1.139%) ⬆️
Sources/Sentry/SentryViewHierarchy.m 98.979% <100.000%> (-0.011%) ⬇️
Sources/Sentry/SentryViewHierarchyIntegration.m 100.000% <100.000%> (ø)
...ations/ANR/SentryANRTrackingIntegrationTests.swift 94.339% <100.000%> (+1.436%) ⬆️
.../Screenshot/SentryScreenshotIntegrationTests.swift 99.382% <100.000%> (+0.091%) ⬆️
...Integrations/Screenshot/TestSentryScreenShot.swift 100.000% <100.000%> (ø)
...ierarchy/SentryViewHierarchyIntegrationTests.swift 99.159% <100.000%> (+0.190%) ⬆️
...ations/ViewHierarchy/TestSentryViewHierarchy.swift 100.000% <100.000%> (ø)
... and 4 more

... and 73 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c96132...78d91d8. Read the comment docs.