Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add visionOS as device family #3548

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Conversation

brustolin
Copy link
Contributor

Added visionOS as device family type. This will be used to filter events.

@brustolin brustolin changed the title feat: Added visionOS as device family feat: Add visionOS as device family Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add visionOS as device family ([#3548](https://github.com/getsentry/sentry-cocoa/pull/3548))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against f0a5f48

Copy link

github-actions bot commented Jan 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.38 ms 1241.00 ms 6.62 ms
Size 21.58 KiB 418.14 KiB 396.56 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
26d116c 1196.14 ms 1209.51 ms 13.37 ms
e324230 1252.69 ms 1274.56 ms 21.87 ms
56ec5d0 1236.65 ms 1261.90 ms 25.25 ms
7cd187e 1243.56 ms 1250.20 ms 6.64 ms
53a8885 1241.02 ms 1270.66 ms 29.64 ms
f74904f 1229.02 ms 1244.91 ms 15.89 ms
881a955 1209.47 ms 1225.94 ms 16.47 ms
98cca71 1199.08 ms 1227.36 ms 28.28 ms
b9a9ffd 1201.61 ms 1215.06 ms 13.45 ms
3e7aa41 1214.02 ms 1238.84 ms 24.82 ms

App size

Revision Plain With Sentry Diff
26d116c 21.58 KiB 417.87 KiB 396.29 KiB
e324230 22.85 KiB 408.87 KiB 386.02 KiB
56ec5d0 20.76 KiB 414.44 KiB 393.69 KiB
7cd187e 20.76 KiB 401.65 KiB 380.89 KiB
53a8885 20.76 KiB 434.65 KiB 413.89 KiB
f74904f 21.58 KiB 418.71 KiB 397.12 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
b9a9ffd 21.58 KiB 418.43 KiB 396.85 KiB
3e7aa41 20.76 KiB 432.31 KiB 411.55 KiB

Previous results on branch: feat/device-family-visionpro

Startup times

Revision Plain With Sentry Diff
f986d75 1194.48 ms 1208.08 ms 13.60 ms

App size

Revision Plain With Sentry Diff
f986d75 21.58 KiB 418.82 KiB 397.23 KiB

Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following on from #3328. I think we'll also need to update a couple other things to use Xcode 15.2, some or all of these:

@brustolin
Copy link
Contributor Author

Following on from #3328. I think we'll also need to update a couple other things to use Xcode 15.2, some or all of these:

Yes, but I think we should create a different PR for this things.

@brustolin
Copy link
Contributor Author

@philipphofmann do you think we can go ahead with this?

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure. LGTM.

@@ -4,6 +4,7 @@

### Features

- Add visionOS as device family (#3548)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: This needs to move up to the unreleased section

@brustolin brustolin merged commit 7207796 into main Jan 29, 2024
25 of 30 checks passed
@brustolin brustolin deleted the feat/device-family-visionpro branch January 29, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants