fix: Finish TTID span when transaction finishes

[philipphofmann]

📜 Description

The tracer finishes when the screen is fully displayed. Therefore, we
must also finish the TTID span.

💡 Motivation and Context

Fixes one part of GH-3588

💚 How did you test it?

Unit tests.

📝 Checklist

You have to check all boxes before merging:

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1280.59 ms	1310.00 ms	29.41 ms
Size	21.58 KiB	418.78 KiB	397.20 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
b6ba04e	1217.45 ms	1248.92 ms	31.47 ms
881a955	1222.94 ms	1246.26 ms	23.32 ms
06548c0	1226.71 ms	1252.37 ms	25.66 ms
c0ff306	1218.92 ms	1240.64 ms	21.72 ms
add9550	1221.20 ms	1250.04 ms	28.84 ms
84fb4d9	1237.76 ms	1255.46 ms	17.70 ms
e8b14db	1193.58 ms	1225.56 ms	31.98 ms
48e8c2e	1222.98 ms	1237.78 ms	14.80 ms
3297d6e	1195.69 ms	1212.35 ms	16.65 ms
8b39743	1258.51 ms	1263.26 ms	4.75 ms

App size

Revision	Plain	With Sentry	Diff
b6ba04e	20.76 KiB	414.45 KiB	393.69 KiB
881a955	22.85 KiB	407.63 KiB	384.78 KiB
06548c0	20.76 KiB	427.36 KiB	406.59 KiB
c0ff306	20.76 KiB	434.65 KiB	413.89 KiB
add9550	21.58 KiB	418.37 KiB	396.79 KiB
84fb4d9	22.84 KiB	402.57 KiB	379.72 KiB
e8b14db	20.76 KiB	401.60 KiB	380.84 KiB
48e8c2e	21.58 KiB	418.44 KiB	396.86 KiB
3297d6e	21.58 KiB	418.44 KiB	396.86 KiB
8b39743	22.85 KiB	413.98 KiB	391.13 KiB

Previous results on branch: fix/not-finishing-ttid-span

Startup times

Revision	Plain	With Sentry	Diff
cedb0fa	1236.92 ms	1254.31 ms	17.39 ms

App size

Revision	Plain	With Sentry	Diff
cedb0fa	21.58 KiB	418.78 KiB	397.19 KiB

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ee8b48f) 89.330% compared to head (5b56804) 89.202%.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #3610       +/-   ##
=============================================
- Coverage   89.330%   89.202%   -0.129%     
=============================================
  Files          529       529               
  Lines        58017     57820      -197     
  Branches     20768     20446      -322     
=============================================
- Hits         51827     51577      -250     
+ Misses        5280      5203       -77     
- Partials       910      1040      +130     

Files	Coverage Δ
Sources/Sentry/SentryTimeToDisplayTracker.m	100.000% <100.000%> (ø)
Sources/Sentry/SentryTracer.m	96.834% <100.000%> (+0.041%)	⬆️
...iewController/SentryTimeToDisplayTrackerTest.swift	99.435% <96.153%> (-0.262%)	⬇️
...ts/SentryTests/Transaction/SentryTracerTests.swift	98.590% <95.833%> (-0.067%)	⬇️

... and 100 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8b48f...5b56804. Read the comment docs.

[brustolin]

LGTM