-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dont take screenshot and view hierarchy for app hanging #3620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @brustolin.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3620 +/- ##
=============================================
- Coverage 89.360% 89.339% -0.022%
=============================================
Files 530 530
Lines 58243 58231 -12
Branches 20891 20883 -8
=============================================
- Hits 52046 52023 -23
- Misses 5173 5183 +10
- Partials 1024 1025 +1
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
43aa39d | 1239.16 ms | 1270.42 ms | 31.26 ms |
af1f4dd | 1232.39 ms | 1255.88 ms | 23.49 ms |
e778bd2 | 1224.66 ms | 1252.16 ms | 27.50 ms |
407ff99 | 1225.49 ms | 1232.88 ms | 7.39 ms |
3297d6e | 1206.80 ms | 1213.86 ms | 7.06 ms |
75ef4eb | 1237.30 ms | 1249.53 ms | 12.23 ms |
89bc37d | 1240.76 ms | 1248.24 ms | 7.48 ms |
d257eb9 | 1226.08 ms | 1256.54 ms | 30.46 ms |
23ce4a9 | 1275.73 ms | 1278.78 ms | 3.05 ms |
7cd187e | 1204.78 ms | 1235.86 ms | 31.08 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
43aa39d | 20.76 KiB | 432.82 KiB | 412.06 KiB |
af1f4dd | 22.85 KiB | 414.71 KiB | 391.86 KiB |
e778bd2 | 20.76 KiB | 426.15 KiB | 405.39 KiB |
407ff99 | 20.76 KiB | 427.87 KiB | 407.10 KiB |
3297d6e | 21.58 KiB | 418.44 KiB | 396.86 KiB |
75ef4eb | 22.85 KiB | 413.45 KiB | 390.60 KiB |
89bc37d | 20.76 KiB | 401.53 KiB | 380.77 KiB |
d257eb9 | 20.76 KiB | 433.23 KiB | 412.47 KiB |
23ce4a9 | 22.85 KiB | 413.45 KiB | 390.60 KiB |
7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
📜 Description
We stop taking screenshot and view hierarchy during app hang events.
💡 Motivation and Context
Main thread is blocked, and its not safe to use ui elements.
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps