-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tags of SentryScope public #3650
Conversation
@philipphofmann can you see any problem with this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3650 +/- ##
=============================================
+ Coverage 89.211% 89.313% +0.102%
=============================================
Files 532 534 +2
Lines 58710 58981 +271
Branches 21077 21171 +94
=============================================
+ Hits 52376 52678 +302
+ Misses 5298 5271 -27
+ Partials 1036 1032 -4
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Nope, as this API is also public for other SDKs, but I would change it to
so you call it with @birdofpreyru, please also add an entry to the changelog, and a test to |
Ok @philipphofmann , I've updated the PR. Re. the tests, I've just updated existing tag-related tests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM 👍
📜 Description
See #3649
💡 Motivation and Context
See #3649
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps