Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Change adding set to string #3792

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Mar 26, 2024

The MetricsAPI for adding a set should accept a string, which gets converted to a CRC32 hash instead of an integer.

This PR is based on #3791.

#skip-changelog

The MetricsAPI for adding a set should accept a string, which gets
converted to a CRC32 hash instead of an integer.
Copy link

github-actions bot commented Mar 26, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a34ff72

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.526%. Comparing base (6cec1cb) to head (4ad6c65).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           feat/metrics     #3792       +/-   ##
==================================================
+ Coverage        89.349%   89.526%   +0.176%     
==================================================
  Files               559       559               
  Lines             60598     60493      -105     
  Branches          21782     21727       -55     
==================================================
+ Hits              54144     54157       +13     
+ Misses             5464      5298      -166     
- Partials            990      1038       +48     
Files Coverage Δ
Sources/Sentry/SentryNSDataUtils.m 95.652% <100.000%> (+0.414%) ⬆️
...urces/Swift/Metrics/BucketsMetricsAggregator.swift 100.000% <100.000%> (ø)
Sources/Swift/Metrics/SentryMetricsAPI.swift 100.000% <100.000%> (ø)
Sources/Swift/Metrics/SetMetric.swift 100.000% <100.000%> (ø)
...entryTests/Categories/SentryNSDataUtilsTests.swift 100.000% <100.000%> (ø)
...tryTests/Swift/Metrics/SentryMetricsAPITests.swift 100.000% <100.000%> (ø)
...sts/SentryTests/Swift/Metrics/SetMetricTests.swift 100.000% <100.000%> (ø)

... and 71 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cec1cb...4ad6c65. Read the comment docs.

Copy link

github-actions bot commented Mar 26, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.43 ms 1249.94 ms 12.51 ms
Size 21.58 KiB 571.85 KiB 550.26 KiB

Baseline results on branch: feat/metrics

Startup times

Revision Plain With Sentry Diff
3303cb5 1230.40 ms 1235.86 ms 5.46 ms

App size

Revision Plain With Sentry Diff
3303cb5 21.58 KiB 571.42 KiB 549.84 KiB

Previous results on branch: feat/strings-for-metric-set

Startup times

Revision Plain With Sentry Diff
d188928 1229.20 ms 1242.69 ms 13.49 ms
2ceec0f 1234.35 ms 1247.24 ms 12.90 ms

App size

Revision Plain With Sentry Diff
d188928 21.58 KiB 571.49 KiB 549.91 KiB
2ceec0f 21.58 KiB 571.49 KiB 549.91 KiB

@philipphofmann philipphofmann merged commit 9aed2e3 into feat/metrics Mar 27, 2024
35 checks passed
@philipphofmann philipphofmann deleted the feat/strings-for-metric-set branch March 27, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants