-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add beforeCaptureScreenshot Callback #4016
Conversation
|
Add a callback to the options to decide if the SDK should capture a screenshot or not. Fixes GH-3137
3d53d8d
to
cdbc68e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4016 +/- ##
=============================================
- Coverage 90.879% 90.854% -0.026%
=============================================
Files 599 598 -1
Lines 46664 46601 -63
Branches 16713 16660 -53
=============================================
- Hits 42408 42339 -69
- Misses 4075 4080 +5
- Partials 181 182 +1
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5d6ce0e | 1227.57 ms | 1241.08 ms | 13.51 ms |
96eb740 | 1231.27 ms | 1243.44 ms | 12.17 ms |
105a36c | 1227.37 ms | 1245.36 ms | 17.99 ms |
1b09e3f | 1227.24 ms | 1242.19 ms | 14.95 ms |
45d3ca5 | 1238.53 ms | 1263.09 ms | 24.55 ms |
1734d1b | 1198.69 ms | 1221.62 ms | 22.93 ms |
0dfdaaa | 1226.88 ms | 1248.82 ms | 21.94 ms |
dfde86d | 1215.12 ms | 1221.30 ms | 6.18 ms |
b868c3a | 1238.45 ms | 1254.98 ms | 16.53 ms |
b35ccd0 | 1224.59 ms | 1241.08 ms | 16.49 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5d6ce0e | 22.85 KiB | 405.38 KiB | 382.53 KiB |
96eb740 | 21.58 KiB | 572.50 KiB | 550.92 KiB |
105a36c | 22.85 KiB | 414.09 KiB | 391.24 KiB |
1b09e3f | 21.58 KiB | 614.93 KiB | 593.34 KiB |
45d3ca5 | 20.76 KiB | 427.54 KiB | 406.78 KiB |
1734d1b | 21.58 KiB | 418.82 KiB | 397.24 KiB |
0dfdaaa | 20.76 KiB | 434.56 KiB | 413.79 KiB |
dfde86d | 21.58 KiB | 414.57 KiB | 392.99 KiB |
b868c3a | 22.85 KiB | 411.17 KiB | 388.32 KiB |
b35ccd0 | 21.58 KiB | 573.14 KiB | 551.56 KiB |
📜 Description
Add a callback to the options to decide if the SDK should capture a screenshot or not.
PR for updating the docs: getsentry/sentry-docs#10152.
💡 Motivation and Context
Fixes GH-3137
💚 How did you test it?
Unit tests and sample app.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps