Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Potential deadlock in app hang detection #4063

Merged
merged 4 commits into from
Jun 14, 2024

changelog

b4ccc53
Select commit
Loading
Failed to load commit list.
Merged

fix: Potential deadlock in app hang detection #4063

changelog
b4ccc53
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 13, 2024 in 0s

91.207% (+0.049%) compared to 2093e05

View this Pull Request on Codecov

91.207% (+0.049%) compared to 2093e05

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.207%. Comparing base (2093e05) to head (b4ccc53).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4063       +/-   ##
=============================================
+ Coverage   91.158%   91.207%   +0.049%     
=============================================
  Files          611       611               
  Lines        48100     48130       +30     
  Branches     17273     17272        -1     
=============================================
+ Hits         43847     43898       +51     
+ Misses        4162      4139       -23     
- Partials        91        93        +2     
Files Coverage Δ
Sources/Sentry/SentryCrashStackEntryMapper.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryStacktraceBuilder.m 77.777% <100.000%> (ø)
Sources/Sentry/SentryThreadInspector.m 99.009% <100.000%> (+0.030%) ⬆️
...tryCrash/Recording/Tools/SentryCrashSymbolicator.c 82.758% <ø> (ø)
...SentryCrash/SentryCrashStackEntryMapperTests.swift 100.000% <100.000%> (ø)
...Tests/SentryCrash/SentryThreadInspectorTests.swift 97.142% <100.000%> (+11.046%) ⬆️
.../SentryTests/SentryCrash/TestThreadInspector.swift 100.000% <100.000%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2093e05...b4ccc53. Read the comment docs.