Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Signals on visionOS #4229

Merged
merged 3 commits into from
Aug 5, 2024
Merged

fix: Signals on visionOS #4229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
133f0b7
fix: Signals on visionOS
miki-shapr Aug 3, 2024
35977a1
Merge branch 'main' into fix/signals-on-visionos
philipphofmann Aug 5, 2024
c305eec
changelog
philipphofmann Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- Guard FramesTracker start and stop (#4224)
- Long-lasting TTID/TTFD spans (#4225). Avoid long TTID spans when the FrameTracker isn't running, which is the case when the app is in the background.
- Missing mach info for crash reports (#4230)
- Crash reports not generated on visionOS (#4229)


### Improvements
Expand Down
8 changes: 4 additions & 4 deletions Sources/Sentry/include/SentryInternalCDefines.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,27 +63,27 @@ typedef unsigned long long bytes;

// Mach APIs are explicitly marked as unavailable in tvOS and watchOS.
// See https://github.com/getsentry/sentry-cocoa/issues/406#issuecomment-1171872518
#if SENTRY_HOST_IOS || SENTRY_HOST_MAC
#if SENTRY_HOST_IOS || SENTRY_HOST_MAC || SENTRY_HOST_VISION
# define SENTRY_HAS_MACH 1
#else
# define SENTRY_HAS_MACH 0
#endif

// signal APIs are explicitly marked as unavailable in watchOS.
// See https://github.com/getsentry/sentry-cocoa/issues/406#issuecomment-1171872518
#if SENTRY_HOST_IOS || SENTRY_HOST_MAC || SENTRY_HOST_TV
#if SENTRY_HOST_IOS || SENTRY_HOST_MAC || SENTRY_HOST_TV || SENTRY_HOST_VISION
# define SENTRY_HAS_SIGNAL 1
#else
# define SENTRY_HAS_SIGNAL 0
#endif

#if SENTRY_HOST_MAC || SENTRY_HOST_IOS
#if SENTRY_HOST_MAC || SENTRY_HOST_IOS || SENTRY_HOST_VISION
# define SENTRY_HAS_SIGNAL_STACK 1
#else
# define SENTRY_HAS_SIGNAL_STACK 0
#endif

#if SENTRY_HOST_MAC || SENTRY_HOST_IOS || SENTRY_HOST_TV
#if SENTRY_HOST_MAC || SENTRY_HOST_IOS || SENTRY_HOST_TV || SENTRY_HOST_VISION
# define SENTRY_HAS_THREADS_API 1
#else
# define SENTRY_HAS_THREADS_API 0
Expand Down
Loading