-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pause replay in session mode when offline #4264
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9ac2b2 | 1241.22 ms | 1256.50 ms | 15.28 ms |
1a86fb2 | 1224.69 ms | 1236.47 ms | 11.77 ms |
8b39743 | 1258.51 ms | 1263.26 ms | 4.75 ms |
5e769dd | 1226.46 ms | 1254.16 ms | 27.70 ms |
3389927 | 1230.12 ms | 1238.04 ms | 7.92 ms |
a54df45 | 1232.62 ms | 1247.30 ms | 14.68 ms |
c3e8f71 | 1243.00 ms | 1251.81 ms | 8.81 ms |
60dd0f5 | 1212.24 ms | 1240.82 ms | 28.58 ms |
4d5eb78 | 1197.86 ms | 1215.73 ms | 17.88 ms |
2deb275 | 1213.47 ms | 1243.63 ms | 30.16 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9ac2b2 | 21.58 KiB | 631.19 KiB | 609.61 KiB |
1a86fb2 | 21.58 KiB | 612.11 KiB | 590.53 KiB |
8b39743 | 22.85 KiB | 413.98 KiB | 391.13 KiB |
5e769dd | 21.58 KiB | 572.21 KiB | 550.63 KiB |
3389927 | 20.76 KiB | 427.23 KiB | 406.46 KiB |
a54df45 | 20.76 KiB | 434.88 KiB | 414.12 KiB |
c3e8f71 | 21.58 KiB | 573.05 KiB | 551.47 KiB |
60dd0f5 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
4d5eb78 | 21.58 KiB | 418.74 KiB | 397.16 KiB |
2deb275 | 21.58 KiB | 681.72 KiB | 660.14 KiB |
Previous results on branch: feat/stop-replay-offline
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bb4705d | 1216.66 ms | 1243.16 ms | 26.50 ms |
5102200 | 1221.57 ms | 1234.04 ms | 12.47 ms |
4a5e583 | 1234.65 ms | 1244.66 ms | 10.01 ms |
71433f8 | 1233.98 ms | 1246.69 ms | 12.71 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bb4705d | 21.58 KiB | 699.93 KiB | 678.35 KiB |
5102200 | 21.58 KiB | 699.89 KiB | 678.31 KiB |
4a5e583 | 21.58 KiB | 700.84 KiB | 679.26 KiB |
71433f8 | 21.58 KiB | 699.93 KiB | 678.35 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4264 +/- ##
=============================================
+ Coverage 91.539% 91.575% +0.036%
=============================================
Files 612 616 +4
Lines 49499 49986 +487
Branches 17922 18069 +147
=============================================
+ Hits 45311 45775 +464
- Misses 4096 4119 +23
Partials 92 92
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I maybe found some synchronization issues.
Tests/SentryTests/Integrations/SessionReplay/SentrySessionReplayTests.swift
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentrySessionReplay.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentrySessionReplay.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙏
📜 Description
If the device has no connection we stop trying to send segments.
We do capture replay for errors,
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps