Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pause replay in session mode when offline #4264

Merged
merged 10 commits into from
Aug 13, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

If the device has no connection we stop trying to send segments.
We do capture replay for errors,

💚 How did you test it?

Unit tests

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Aug 8, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9ba46b1

Copy link

github-actions bot commented Aug 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1242.61 ms 1253.81 ms 11.20 ms
Size 21.58 KiB 705.27 KiB 683.69 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a9ac2b2 1241.22 ms 1256.50 ms 15.28 ms
1a86fb2 1224.69 ms 1236.47 ms 11.77 ms
8b39743 1258.51 ms 1263.26 ms 4.75 ms
5e769dd 1226.46 ms 1254.16 ms 27.70 ms
3389927 1230.12 ms 1238.04 ms 7.92 ms
a54df45 1232.62 ms 1247.30 ms 14.68 ms
c3e8f71 1243.00 ms 1251.81 ms 8.81 ms
60dd0f5 1212.24 ms 1240.82 ms 28.58 ms
4d5eb78 1197.86 ms 1215.73 ms 17.88 ms
2deb275 1213.47 ms 1243.63 ms 30.16 ms

App size

Revision Plain With Sentry Diff
a9ac2b2 21.58 KiB 631.19 KiB 609.61 KiB
1a86fb2 21.58 KiB 612.11 KiB 590.53 KiB
8b39743 22.85 KiB 413.98 KiB 391.13 KiB
5e769dd 21.58 KiB 572.21 KiB 550.63 KiB
3389927 20.76 KiB 427.23 KiB 406.46 KiB
a54df45 20.76 KiB 434.88 KiB 414.12 KiB
c3e8f71 21.58 KiB 573.05 KiB 551.47 KiB
60dd0f5 20.76 KiB 393.37 KiB 372.61 KiB
4d5eb78 21.58 KiB 418.74 KiB 397.16 KiB
2deb275 21.58 KiB 681.72 KiB 660.14 KiB

Previous results on branch: feat/stop-replay-offline

Startup times

Revision Plain With Sentry Diff
bb4705d 1216.66 ms 1243.16 ms 26.50 ms
5102200 1221.57 ms 1234.04 ms 12.47 ms
4a5e583 1234.65 ms 1244.66 ms 10.01 ms
71433f8 1233.98 ms 1246.69 ms 12.71 ms

App size

Revision Plain With Sentry Diff
bb4705d 21.58 KiB 699.93 KiB 678.35 KiB
5102200 21.58 KiB 699.89 KiB 678.31 KiB
4a5e583 21.58 KiB 700.84 KiB 679.26 KiB
71433f8 21.58 KiB 699.93 KiB 678.35 KiB

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.575%. Comparing base (594c2e6) to head (9ba46b1).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4264       +/-   ##
=============================================
+ Coverage   91.539%   91.575%   +0.036%     
=============================================
  Files          612       616        +4     
  Lines        49499     49986      +487     
  Branches     17922     18069      +147     
=============================================
+ Hits         45311     45775      +464     
- Misses        4096      4119       +23     
  Partials        92        92               
Files Coverage Δ
Sources/Sentry/SentrySessionReplayIntegration.m 85.585% <100.000%> (+0.332%) ⬆️
...tegrations/SessionReplay/SentrySessionReplay.swift 93.373% <100.000%> (+0.610%) ⬆️
...onReplay/SentrySessionReplayIntegrationTests.swift 98.598% <100.000%> (+0.054%) ⬆️
...tions/SessionReplay/SentrySessionReplayTests.swift 97.989% <100.000%> (+0.570%) ⬆️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 594c2e6...9ba46b1. Read the comment docs.

@brustolin brustolin marked this pull request as ready for review August 9, 2024 13:36
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I maybe found some synchronization issues.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@brustolin brustolin merged commit 5c23b77 into main Aug 13, 2024
65 checks passed
@brustolin brustolin deleted the feat/stop-replay-offline branch August 13, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants