Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds SentryFileManager and SentrySerialization to dangerous files #4307

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

kahest
Copy link
Member

@kahest kahest commented Sep 3, 2024

📜 Description

💡 Motivation and Context

Adds SentryFileManager and SentrySerialization to list of dangerous files. A recent (GH-4219) change in these files is the likely root cause of invalid envelopes that subsequently caused crashes.

#skip-changelog

💚 How did you test it?

n/a

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should discuss the procedure we should take when some of these files are changed. The alert itself would not prevent the previous problem since the changes to these files were the target of the PR. In these cases, the alert is ignored.

@kahest kahest merged commit 8b1c6a9 into main Sep 3, 2024
8 checks passed
@kahest kahest deleted the kahest/add-files-to-file-filter branch September 3, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants