Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added UI Test to check invalid envelope is handled correct #4312

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Sep 4, 2024

This is a test that will detect the problem introduced in v8.33.0

Running the same test in v8.33 would result in the following:

Screenshot 2024-09-04 at 16 23 14

#skip-changelog

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.675%. Comparing base (8411a0a) to head (83e825e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4312       +/-   ##
=============================================
+ Coverage   91.665%   91.675%   +0.009%     
=============================================
  Files          617       617               
  Lines        50238     50237        -1     
  Branches     18156     18135       -21     
=============================================
+ Hits         46051     46055        +4     
+ Misses        4095      4089        -6     
- Partials        92        93        +1     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8411a0a...83e825e. Read the comment docs.

Copy link

github-actions bot commented Sep 4, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.23 ms 1231.15 ms 17.91 ms
Size 21.58 KiB 707.43 KiB 685.85 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c78683b 1255.78 ms 1261.94 ms 6.16 ms
3437454 1225.64 ms 1234.31 ms 8.67 ms
881a955 1222.16 ms 1237.22 ms 15.06 ms
fd6a31c 1190.43 ms 1218.78 ms 28.35 ms
28c80b5 1198.63 ms 1214.08 ms 15.45 ms
ddb4778 1274.37 ms 1284.48 ms 10.11 ms
77c9c47 1236.98 ms 1250.43 ms 13.45 ms
408f43e 1229.31 ms 1247.52 ms 18.21 ms
3fd6a8b 1221.87 ms 1248.82 ms 26.95 ms
a0cc9d6 1232.37 ms 1249.55 ms 17.18 ms

App size

Revision Plain With Sentry Diff
c78683b 20.76 KiB 435.24 KiB 414.47 KiB
3437454 22.85 KiB 408.87 KiB 386.02 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB
fd6a31c 20.76 KiB 436.50 KiB 415.74 KiB
28c80b5 21.58 KiB 417.85 KiB 396.27 KiB
ddb4778 21.58 KiB 414.92 KiB 393.34 KiB
77c9c47 21.58 KiB 641.28 KiB 619.70 KiB
408f43e 21.58 KiB 573.17 KiB 551.59 KiB
3fd6a8b 21.58 KiB 706.98 KiB 685.40 KiB
a0cc9d6 21.58 KiB 706.46 KiB 684.88 KiB

Previous results on branch: chore/test-invalid-envelope

Startup times

Revision Plain With Sentry Diff
779801b 1226.22 ms 1248.98 ms 22.76 ms
79cfb9b 1232.33 ms 1240.73 ms 8.41 ms

App size

Revision Plain With Sentry Diff
779801b 21.58 KiB 707.43 KiB 685.85 KiB
79cfb9b 21.58 KiB 706.97 KiB 685.39 KiB

Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the last suggestion from @kahest goes in 👍🏻

Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
@brustolin brustolin merged commit bec7914 into main Sep 5, 2024
58 checks passed
@brustolin brustolin deleted the chore/test-invalid-envelope branch September 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants