-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Moving session replay public API and default quality #4326
Conversation
…lt quality to `medium`
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1bf8571 | 1250.96 ms | 1255.36 ms | 4.40 ms |
236d8a8 | 1232.33 ms | 1255.55 ms | 23.22 ms |
b9b0f0a | 1235.61 ms | 1237.40 ms | 1.79 ms |
94e1968 | 1230.22 ms | 1253.33 ms | 23.11 ms |
0341c52 | 1235.76 ms | 1246.67 ms | 10.91 ms |
fc163f5 | 1198.05 ms | 1227.76 ms | 29.71 ms |
dbc67d2 | 1239.49 ms | 1248.88 ms | 9.39 ms |
dc0fe58 | 1198.56 ms | 1220.98 ms | 22.42 ms |
f5623cd | 1255.78 ms | 1262.30 ms | 6.52 ms |
9dbf743 | 1252.10 ms | 1262.10 ms | 10.00 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1bf8571 | 20.76 KiB | 437.12 KiB | 416.36 KiB |
236d8a8 | 21.58 KiB | 418.70 KiB | 397.12 KiB |
b9b0f0a | 20.76 KiB | 434.93 KiB | 414.17 KiB |
94e1968 | 21.58 KiB | 614.74 KiB | 593.15 KiB |
0341c52 | 21.58 KiB | 544.86 KiB | 523.27 KiB |
fc163f5 | 20.76 KiB | 436.30 KiB | 415.54 KiB |
dbc67d2 | 20.76 KiB | 427.74 KiB | 406.98 KiB |
dc0fe58 | 20.76 KiB | 436.50 KiB | 415.74 KiB |
f5623cd | 22.85 KiB | 412.98 KiB | 390.13 KiB |
9dbf743 | 20.76 KiB | 434.94 KiB | 414.18 KiB |
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4326 +/- ##
=============================================
+ Coverage 91.659% 91.669% +0.009%
=============================================
Files 617 618 +1
Lines 50236 50248 +12
Branches 18150 18151 +1
=============================================
+ Hits 46046 46062 +16
+ Misses 4098 4093 -5
- Partials 92 93 +1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
📜 Description
Moved session replay API to
SentrySDK.replay
and changed default quality tomedium
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps