Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Moving session replay public API and default quality #4326

Merged
merged 17 commits into from
Sep 12, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Moved session replay API to SentrySDK.replay and changed default quality to medium

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Sep 11, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.02 ms 1252.13 ms 17.11 ms
Size 21.58 KiB 707.96 KiB 686.38 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1bf8571 1250.96 ms 1255.36 ms 4.40 ms
236d8a8 1232.33 ms 1255.55 ms 23.22 ms
b9b0f0a 1235.61 ms 1237.40 ms 1.79 ms
94e1968 1230.22 ms 1253.33 ms 23.11 ms
0341c52 1235.76 ms 1246.67 ms 10.91 ms
fc163f5 1198.05 ms 1227.76 ms 29.71 ms
dbc67d2 1239.49 ms 1248.88 ms 9.39 ms
dc0fe58 1198.56 ms 1220.98 ms 22.42 ms
f5623cd 1255.78 ms 1262.30 ms 6.52 ms
9dbf743 1252.10 ms 1262.10 ms 10.00 ms

App size

Revision Plain With Sentry Diff
1bf8571 20.76 KiB 437.12 KiB 416.36 KiB
236d8a8 21.58 KiB 418.70 KiB 397.12 KiB
b9b0f0a 20.76 KiB 434.93 KiB 414.17 KiB
94e1968 21.58 KiB 614.74 KiB 593.15 KiB
0341c52 21.58 KiB 544.86 KiB 523.27 KiB
fc163f5 20.76 KiB 436.30 KiB 415.54 KiB
dbc67d2 20.76 KiB 427.74 KiB 406.98 KiB
dc0fe58 20.76 KiB 436.50 KiB 415.74 KiB
f5623cd 22.85 KiB 412.98 KiB 390.13 KiB
9dbf743 20.76 KiB 434.94 KiB 414.18 KiB

Previous results on branch: ref/replay-api

Startup times

Revision Plain With Sentry Diff
216a035 1225.60 ms 1247.53 ms 21.93 ms

App size

Revision Plain With Sentry Diff
216a035 21.58 KiB 707.99 KiB 686.40 KiB

CHANGELOG.md Outdated Show resolved Hide resolved
brustolin and others added 2 commits September 11, 2024 16:57
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.669%. Comparing base (087a3b3) to head (56dfd75).

Files with missing lines Patch % Lines
Sources/Sentry/SentryReplayApi.m 50.000% 2 Missing ⚠️
Sources/Sentry/SentrySessionReplayIntegration.m 90.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4326       +/-   ##
=============================================
+ Coverage   91.659%   91.669%   +0.009%     
=============================================
  Files          617       618        +1     
  Lines        50236     50248       +12     
  Branches     18150     18151        +1     
=============================================
+ Hits         46046     46062       +16     
+ Misses        4098      4093        -5     
- Partials        92        93        +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySDK.m 88.950% <100.000%> (+0.123%) ⬆️
...tegrations/SessionReplay/SentryReplayOptions.swift 93.103% <100.000%> (ø)
...tegrations/SessionReplay/SentrySessionReplay.swift 93.373% <100.000%> (ø)
...tions/SessionReplay/SentryReplayOptionsTests.swift 100.000% <100.000%> (ø)
...tions/SessionReplay/SentrySessionReplayTests.swift 97.989% <100.000%> (ø)
Tests/SentryTests/UIRedactBuilderTests.swift 100.000% <100.000%> (ø)
Sources/Sentry/SentrySessionReplayIntegration.m 85.398% <90.000%> (-0.188%) ⬇️
Sources/Sentry/SentryReplayApi.m 50.000% <50.000%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087a3b3...56dfd75. Read the comment docs.

@brustolin brustolin merged commit e1c3819 into main Sep 12, 2024
@brustolin brustolin deleted the ref/replay-api branch September 12, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants