-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Changing the redact logic #4327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sentry/sentry-cocoa into fix/redact-under-translucent
7 tasks
…y-cocoa into fix/redact-logic
brustolin
requested review from
philipphofmann and
armcknight
as code owners
September 12, 2024 13:55
A label that is outside of bounds of a view with clipBounds true is no longer being redacted.
Base automatically changed from
fix/out-of-clip-redact
to
fix/redact-under-translucent
September 13, 2024 13:56
brustolin
commented
Sep 16, 2024
…y-cocoa into fix/redact-logic
…ry/sentry-cocoa into fix/redact-logic" This reverts commit f634c33, reversing changes made to 57a9d0c.
philipphofmann
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few suggestions 👍
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Before this PR,
redactAllText
was wrongly used as a "redact is enabled" flag.Now we're using
redactAllText
andredactAllImages
as an indicator to how start the redact list:An exception is UIWebView and WKWebView that are always added to redact view.
Also, we're making a change to the ignoreRedact behaviour, that will not be inherited by its subviews.
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.