-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Finish TTID when viewWillAppear is skipped #4417
Conversation
According to the Apple docs, viewWillAppear should be called before the UIViewController is added to the view hierarchy. There are some edge cases, though, when this doesn't happen, and we saw customers' transactions also proofing this. Therefore, we must also report the initial display here, as the customers' transactions had spans for viewWillLayoutSubViews. Fixes GH-4383
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4417 +/- ##
=============================================
+ Coverage 91.303% 91.321% +0.018%
=============================================
Files 609 609
Lines 49570 49630 +60
Branches 17857 17894 +37
=============================================
+ Hits 45259 45323 +64
+ Misses 4218 4216 -2
+ Partials 93 91 -2
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7cd187e | 1239.39 ms | 1258.02 ms | 18.63 ms |
5e66a38 | 1209.10 ms | 1233.90 ms | 24.79 ms |
d760c3f | 1200.95 ms | 1233.96 ms | 33.00 ms |
324dc7b | 1210.33 ms | 1244.92 ms | 34.59 ms |
62c15d4 | 1231.80 ms | 1248.86 ms | 17.06 ms |
9faf217 | 1268.86 ms | 1274.82 ms | 5.96 ms |
39b1c35 | 1236.35 ms | 1239.90 ms | 3.55 ms |
5d6ce0e | 1237.10 ms | 1257.46 ms | 20.36 ms |
5c115c5 | 1249.04 ms | 1260.36 ms | 11.32 ms |
50bb751 | 1230.94 ms | 1238.69 ms | 7.75 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
5e66a38 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
d760c3f | 22.84 KiB | 403.17 KiB | 380.33 KiB |
324dc7b | 22.85 KiB | 408.84 KiB | 385.99 KiB |
62c15d4 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
9faf217 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
39b1c35 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
5d6ce0e | 22.85 KiB | 405.38 KiB | 382.53 KiB |
5c115c5 | 22.85 KiB | 411.72 KiB | 388.87 KiB |
50bb751 | 21.58 KiB | 417.86 KiB | 396.27 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one suggestion, but it looks good to me
📜 Description
According to the Apple docs, viewWillAppear should be called before the UIViewController is added to the view hierarchy. There are some edge cases, though, when this doesn't happen, and we saw customers' transactions also proofing this. Therefore, we must also report the initial display here, as the customers' transactions had spans for viewWillLayoutSubViews.
💡 Motivation and Context
Fixes GH-4383
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps