Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feedback): bubble up feedback capture to objc layer #4659

Merged
merged 2 commits into from
Dec 23, 2024

remove public from function

6ddc831
Select commit
Loading
Failed to load commit list.
Merged

fix(feedback): bubble up feedback capture to objc layer #4659

remove public from function
6ddc831
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 23, 2024 in 0s

0.000% of diff hit (target 90.594%)

View this Pull Request on Codecov

0.000% of diff hit (target 90.594%)

Annotations

Check warning on line 23 in Sources/Sentry/SentryUserFeedbackIntegration.m

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Sentry/SentryUserFeedbackIntegration.m#L22-L23 

Added lines #L22 - L23 were not covered by tests

Check warning on line 32 in Sources/Sentry/SentryUserFeedbackIntegration.m

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Sentry/SentryUserFeedbackIntegration.m#L31-L32 

Added lines #L31 - L32 were not covered by tests

Check warning on line 139 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift#L139 

Added line #L139 was not covered by tests

Check warning on line 143 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift#L143 

Added line #L143 was not covered by tests

Check warning on line 24 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackIntegrationDriver.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackIntegrationDriver.swift#L24 

Added line #L24 was not covered by tests

Check warning on line 59 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackIntegrationDriver.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackIntegrationDriver.swift#L59 

Added line #L59 was not covered by tests

Check warning on line 93 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackIntegrationDriver.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackIntegrationDriver.swift#L92-L93 

Added lines #L92 - L93 were not covered by tests

Check warning on line 33 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidget.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidget.swift#L33 

Added line #L33 was not covered by tests

Check warning on line 80 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidget.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidget.swift#L80 

Added line #L80 was not covered by tests

Check warning on line 82 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidget.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidget.swift#L82 

Added line #L82 was not covered by tests

Check warning on line 95 in Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidget.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackWidget.swift#L95 

Added line #L95 was not covered by tests
View more details on Codecov