Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deserialize User #4732

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jan 21, 2025

This PR is based on #4724.

Adds the Decodable implementation for SentryUser, including decoding arbitrary data.

#skip-changelog

Copy link

github-actions bot commented Jan 21, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d94c1cd

Copy link

github-actions bot commented Jan 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.77 ms 1237.33 ms 14.56 ms
Size 22.31 KiB 778.51 KiB 756.19 KiB

Baseline results on branch: feat/deserializing-events

Startup times

Revision Plain With Sentry Diff
04e8394 1223.24 ms 1244.33 ms 21.08 ms
8dae1f6 1212.60 ms 1226.52 ms 13.93 ms
8a562cc 1228.57 ms 1245.18 ms 16.60 ms

App size

Revision Plain With Sentry Diff
04e8394 22.31 KiB 771.93 KiB 749.62 KiB
8dae1f6 22.31 KiB 772.51 KiB 750.20 KiB
8a562cc 22.31 KiB 773.33 KiB 751.02 KiB

Previous results on branch: feat/deserializing-user

Startup times

Revision Plain With Sentry Diff
e8ba305 1222.62 ms 1246.81 ms 24.19 ms
e7fdb8c 1221.47 ms 1252.20 ms 30.74 ms

App size

Revision Plain With Sentry Diff
e8ba305 22.31 KiB 778.51 KiB 756.19 KiB
e7fdb8c 22.31 KiB 778.51 KiB 756.20 KiB

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 99.13295% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.259%. Comparing base (5f63edf) to head (d94c1cd).
Report is 7 commits behind head on feat/deserializing-events.

Files with missing lines Patch % Lines
...s/Swift/Protocol/Codable/DecodeArbitraryData.swift 95.774% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##           feat/deserializing-events     #4732       +/-   ##
===============================================================
+ Coverage                     91.082%   91.259%   +0.176%     
===============================================================
  Files                            627       627               
  Lines                          72288     72795      +507     
  Branches                       25675     26511      +836     
===============================================================
+ Hits                           65842     66432      +590     
+ Misses                          6351      6267       -84     
- Partials                          95        96        +1     
Files with missing lines Coverage Δ
Sources/Swift/Protocol/Codable/SentryCodable.swift 100.000% <100.000%> (ø)
...ces/Swift/Protocol/Codable/SentryUserCodable.swift 100.000% <100.000%> (ø)
...tryTests/Protocol/Codable/ArbitraryDataTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/Protocol/SentryUserTests.swift 100.000% <100.000%> (ø)
...s/Swift/Protocol/Codable/DecodeArbitraryData.swift 95.774% <95.774%> (ø)

... and 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f63edf...d94c1cd. Read the comment docs.

@philipphofmann philipphofmann merged commit 0ec0fd1 into feat/deserializing-events Jan 21, 2025
66 of 69 checks passed
@philipphofmann philipphofmann deleted the feat/deserializing-user branch January 21, 2025 14:32
@philipphofmann philipphofmann mentioned this pull request Jan 23, 2025
7 tasks
@philipphofmann philipphofmann self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants