test: iOS sample app debug menu #5222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2025
armcknight
force-pushed
the
armcknight/test/sample-app-debug-menu
branch
from
1869fe9 to
3ece86a
Compare
armcknight
changed the base branch from
main
to
armcknight/test/restart-sdk-on-reconfig
Contributor
Performance metrics 🚀
|
philipphofmann
approved these changes
May 13, 2025
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM, when CI is green.
Member
Author
|
I believe the remaining CI failures are flakes |
armcknight
merged commit c66e1d3
into
armcknight/test/restart-sdk-on-reconfig
54 of 59 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the feature flag table view shared in #5199 available to all iOS sample apps. Moved it from its spot in iOS-Swift where a button in the Extras tab would push it to a nav controller, to showing a floating button in an overlay window that presents the list modally (dismissable with a swipe down).
Future work should move the DSN view on each screen of iOS-Swift into this modal as well. (see #5228)
It is shown in iOS-ObjectiveC but be aware that that app doesn't yet respect all the possible flags. This should be taken care of in #5201 .
#skip-changelog