Skip to content

Conversation

@philprime
Copy link
Member

I could not find a use case of this, so we can remove it.

#skip-changelog

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime self-assigned this Jun 23, 2025
@philprime
Copy link
Member Author

Moving back to draft because it seems to have issues I need to investigate.

@philprime philprime marked this pull request as draft June 23, 2025 14:42
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.286%. Comparing base (5258fb8) to head (daa03d1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5463       +/-   ##
=============================================
+ Coverage   86.283%   86.286%   +0.002%     
=============================================
  Files          407       407               
  Lines        35096     35089        -7     
  Branches     15234     15233        -1     
=============================================
- Hits         30282     30277        -5     
- Misses        4768      4769        +1     
+ Partials        46        43        -3     
Files with missing lines Coverage Δ
Sources/Sentry/SentryNSProcessInfoWrapper.mm 83.333% <ø> (+16.666%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5258fb8...daa03d1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.00 ms 1255.22 ms 29.22 ms
Size 23.75 KiB 874.17 KiB 850.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b714cb9 1224.71 ms 1238.04 ms 13.33 ms
55f739c 1226.06 ms 1248.78 ms 22.71 ms
65f8d2e 1221.15 ms 1243.96 ms 22.81 ms
32e7197 1226.91 ms 1245.48 ms 18.56 ms
d7461dc 1233.69 ms 1255.29 ms 21.60 ms
b0e13a7 1227.71 ms 1245.88 ms 18.16 ms
f92cfa9 1228.45 ms 1251.33 ms 22.88 ms
2609f7a 1218.17 ms 1241.34 ms 23.17 ms
e18d392 1228.69 ms 1244.43 ms 15.73 ms
e64d3d4 1241.90 ms 1260.10 ms 18.20 ms

App size

Revision Plain With Sentry Diff
b714cb9 23.75 KiB 858.69 KiB 834.93 KiB
55f739c 23.75 KiB 858.73 KiB 834.98 KiB
65f8d2e 23.74 KiB 872.67 KiB 848.93 KiB
32e7197 23.75 KiB 866.69 KiB 842.94 KiB
d7461dc 23.75 KiB 874.45 KiB 850.70 KiB
b0e13a7 23.75 KiB 860.98 KiB 837.23 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.62 KiB
2609f7a 23.75 KiB 867.04 KiB 843.29 KiB
e18d392 23.75 KiB 866.68 KiB 842.93 KiB
e64d3d4 23.75 KiB 855.37 KiB 831.62 KiB

@philprime philprime marked this pull request as ready for review July 7, 2025 12:21
@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Jul 7, 2025
@philprime philprime merged commit c3fece5 into main Jul 7, 2025
134 of 136 checks passed
@philprime philprime deleted the philprime/remove-unused-singleton branch July 7, 2025 12:27
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants