test: Improve critical crash test #5530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Launch the app after crash in the background and wait for 5 seconds for it to launch. If it doesn't launch after 5 seconds exit the test as failed.
philipphofmann
requested review from
NicoHinderling,
armcknight,
itaybre,
noahsmartin,
philprime and
trevor-e
as code owners
noahsmartin
approved these changes
Jul 2, 2025
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
This reverts commit 231031e.
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
This reverts commit 231031e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch the app after crash in the background and wait for 5 seconds for it to launch. If it doesn't launch after 5 seconds exit the test as failed.
Follow up on #5528 cause the test timed out here https://github.com/getsentry/sentry-cocoa/actions/runs/15985146703/job/45087995982