test: Improve corrupted envelope UI test #5549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the UI test by writing the corrupted envelope and then starting the SDK. This removes the need to relaunch the app, which often is problematic in CI. Furthermore, this PR now lets the UI test fail with an error message if the test can't write the corrupted envelope instead of using fatalError. So when this fails, we know clearly what went wrong.
philipphofmann
requested review from
NicoHinderling,
armcknight,
itaybre,
noahsmartin,
philprime and
trevor-e
as code owners
noahsmartin
reviewed
Jul 2, 2025
TestSamples/SwiftUITestSample/SwiftUITestSample/SwiftUITestSampleApp.swift
Outdated
Show resolved
Hide resolved
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
This reverts commit aa96485.
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
This reverts commit aa96485.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the UI test by writing the corrupted envelope and then starting the SDK. This removes the need to relaunch the app, which often is problematic in CI. Furthermore, this PR now lets the UI test fail with an error message if the test can't write the corrupted envelope instead of using fatalError. So when this fails, we know clearly what went wrong.
Helps with #5422.
#skip-changelog