Skip to content

Conversation

@noahsmartin
Copy link
Contributor

Allow access to this property for RN SDK, see getsentry/sentry-react-native#4988

#skip-changelog

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.469%. Comparing base (30f4e4c) to head (bc00ca1).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5606       +/-   ##
=============================================
+ Coverage   86.427%   86.469%   +0.041%     
=============================================
  Files          414       414               
  Lines        35271     35282       +11     
  Branches     15283     15321       +38     
=============================================
+ Hits         30484     30508       +24     
+ Misses        4740      4728       -12     
+ Partials        47        46        -1     
Files with missing lines Coverage Δ
...rations/SessionReplay/RRWeb/SentryRRWebEvent.swift 100.000% <ø> (ø)

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f4e4c...bc00ca1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
I've tested the fix locally with sentry-react-native and confirmed that the SentryRRWebEvent.data is now visible.
Thank you for the quick fix @noahsmartin and for fixing the APPLICATION_EXTENSION_API_ONLY issue 🙇

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.24 ms 1246.53 ms 29.29 ms
Size 23.75 KiB 879.53 KiB 855.78 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fc0757d 1231.83 ms 1248.98 ms 17.15 ms
186f06f 1211.33 ms 1235.41 ms 24.08 ms
2a36c3f 1227.27 ms 1246.89 ms 19.63 ms
f92cfa9 1217.94 ms 1240.06 ms 22.12 ms
ccf1278 1226.84 ms 1248.51 ms 21.67 ms
ea5a59b 1222.87 ms 1253.47 ms 30.60 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms
7908e84 1224.33 ms 1246.39 ms 22.06 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms
b714cb9 1224.71 ms 1238.04 ms 13.33 ms

App size

Revision Plain With Sentry Diff
fc0757d 23.75 KiB 850.73 KiB 826.98 KiB
186f06f 23.75 KiB 876.94 KiB 853.19 KiB
2a36c3f 23.75 KiB 874.45 KiB 850.71 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.63 KiB
ccf1278 23.75 KiB 877.15 KiB 853.40 KiB
ea5a59b 23.75 KiB 874.46 KiB 850.71 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
7908e84 23.74 KiB 872.75 KiB 849.00 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB
b714cb9 23.75 KiB 858.69 KiB 834.93 KiB

@noahsmartin noahsmartin merged commit a9fac2e into main Jul 10, 2025
139 of 143 checks passed
@noahsmartin noahsmartin deleted the updateVisibilityForRNSdk branch July 10, 2025 16:07
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants