-
-
Notifications
You must be signed in to change notification settings - Fork 372
feat(SPM) Convert SentrySDK to Swift #5683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #5683 +/- ##
=============================================
+ Coverage 86.565% 86.657% +0.092%
=============================================
Files 421 422 +1
Lines 36049 36126 +77
Branches 15350 17014 +1664
=============================================
+ Hits 31206 31306 +100
+ Misses 4805 4772 -33
- Partials 38 48 +10
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
8519c42 to
72c6377
Compare
85f26c0 to
0ae81ed
Compare
0ae81ed to
09a529e
Compare
armcknight
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for taking it on! Feel free to merge when CI is happy 🤖
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 079bcc8 | 1217.88 ms | 1234.88 ms | 17.00 ms |
| d7461dc | 1233.69 ms | 1255.29 ms | 21.60 ms |
| 2691350 | 1224.92 ms | 1255.82 ms | 30.90 ms |
| f92cfa9 | 1217.94 ms | 1240.06 ms | 22.12 ms |
| 53b722c | 1222.33 ms | 1244.90 ms | 22.56 ms |
| 43597ba | 1214.88 ms | 1243.52 ms | 28.65 ms |
| d637379 | 1226.43 ms | 1250.77 ms | 24.34 ms |
| a2a3bfb | 1227.94 ms | 1261.26 ms | 33.32 ms |
| bce9765 | 1229.42 ms | 1243.49 ms | 14.07 ms |
| 7c7ac56 | 1225.90 ms | 1250.22 ms | 24.33 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 079bcc8 | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| d7461dc | 23.75 KiB | 874.45 KiB | 850.70 KiB |
| 2691350 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| f92cfa9 | 23.75 KiB | 855.38 KiB | 831.63 KiB |
| 53b722c | 23.75 KiB | 906.08 KiB | 882.33 KiB |
| 43597ba | 23.75 KiB | 880.32 KiB | 856.58 KiB |
| d637379 | 23.75 KiB | 855.38 KiB | 831.63 KiB |
| a2a3bfb | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| bce9765 | 23.74 KiB | 874.06 KiB | 850.32 KiB |
| 7c7ac56 | 23.75 KiB | 902.49 KiB | 878.74 KiB |
This reverts commit c2982e7.
This reverts commit c2982e7.
This converts SentrySDK to Swift. It's a pretty straightforward conversion since I had already refactored SentrySDKInternal to contain all the implementation, the biggest changes here are around SPM support. In SPM you can't have Swift code that calls an ObjC API that uses a Swift type. This means the Swift/ObjC bridge needs to only contains ObjC types. That leads to 3 changes in this PR:
Other than those 3 changes this PR is just copying the interface to Swift. The number of lines changes is big because the sdk_api json files change but the changes are just internal to how the file represents Swift vs. ObjC definitions, not breaking changes.
#skip-changelog