Skip to content

Conversation

@armcknight
Copy link
Member

I noticed that sometimes unit test jobs still report failures even though no tests fail, with the script exiting nonzero. See https://github.com/getsentry/sentry-cocoa/actions/runs/16505144160/job/46673775222

I thought maybe this is actually an error coming from slather. Separate that into its own step so we can isolate potential failures.

#skip-changelog

@codecov
Copy link

codecov bot commented Jul 24, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
27833 1 27832 85
View the top 1 failed test(s) by shortest run time
SentryTracerTests::testConcurrentTransactions_OnlyOneGetsMeasurement
Stack Traces | 0s run time
Restarting after unexpected exit, crash, or test timeout in SentryTracerTests.testConcurrentTransactions_OnlyOneGetsMeasurement(); summary will include totals from previous launches.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks

@itaybre
Copy link
Contributor

itaybre commented Jul 29, 2025

Looks like this still failed with the same error here.
Might be related to the teardown of xcodebuild, not the slather step

@armcknight armcknight merged commit 438caec into main Aug 5, 2025
21 of 25 checks passed
@armcknight armcknight deleted the armcknight/tests/slather branch August 5, 2025 22:49
philprime pushed a commit that referenced this pull request Aug 6, 2025
Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants