Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Jul 28, 2025

This PR is derived from #5572 in an effort to make the large amount of changes easier to review for #5577.

Should be merged after #5737

Fixes nullability handling and tests for the SentryArray sanitization utilities.

#skip-changelog

@philprime philprime self-assigned this Jul 28, 2025
@philprime philprime changed the base branch from philprime/strict-nullability-1 to philprime/strict-nullability-2 July 28, 2025 11:09
@philprime philprime force-pushed the philprime/strict-nullability-3 branch from cc5cf30 to 573ffec Compare July 28, 2025 11:32
@philprime philprime force-pushed the philprime/strict-nullability-2 branch from 7ee18c8 to d0f82c6 Compare July 28, 2025 11:34
@philprime philprime force-pushed the philprime/strict-nullability-3 branch from 573ffec to 4d63e77 Compare July 28, 2025 11:39
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.707%. Comparing base (ebc72be) to head (5975a8c).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5738       +/-   ##
=============================================
+ Coverage   86.187%   86.707%   +0.520%     
=============================================
  Files          423       423               
  Lines        36106     36172       +66     
  Branches     15246     17021     +1775     
=============================================
+ Hits         31119     31364      +245     
+ Misses        4944      4527      -417     
- Partials        43       281      +238     
Files with missing lines Coverage Δ
Sources/Sentry/SentryArray.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryNSDictionarySanitize.m 100.000% <ø> (ø)

... and 62 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc72be...5975a8c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.16 ms 1251.57 ms 28.41 ms
Size 23.75 KiB 908.16 KiB 884.41 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f8029e2 1245.16 ms 1261.32 ms 16.16 ms
2481950 1221.04 ms 1248.98 ms 27.94 ms
15c8cd5 1220.24 ms 1246.14 ms 25.90 ms
e64d3d4 1241.90 ms 1260.10 ms 18.20 ms
fac4ca3 1222.81 ms 1235.83 ms 13.02 ms
51f74d7 1236.31 ms 1247.43 ms 11.12 ms
5c5648e 1234.44 ms 1253.79 ms 19.35 ms
5ec90e0 1235.57 ms 1258.45 ms 22.88 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms
c63e0fe 1230.58 ms 1253.94 ms 23.35 ms

App size

Revision Plain With Sentry Diff
f8029e2 23.75 KiB 893.72 KiB 869.97 KiB
2481950 23.74 KiB 872.74 KiB 849.00 KiB
15c8cd5 23.75 KiB 908.01 KiB 884.26 KiB
e64d3d4 23.75 KiB 855.37 KiB 831.62 KiB
fac4ca3 23.75 KiB 902.01 KiB 878.27 KiB
51f74d7 23.74 KiB 874.08 KiB 850.34 KiB
5c5648e 23.75 KiB 879.60 KiB 855.86 KiB
5ec90e0 23.74 KiB 872.67 KiB 848.92 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
c63e0fe 23.74 KiB 874.08 KiB 850.33 KiB

Previous results on branch: philprime/strict-nullability-3

Startup times

Revision Plain With Sentry Diff
dd24cb0 1239.45 ms 1262.78 ms 23.33 ms

App size

Revision Plain With Sentry Diff
dd24cb0 23.75 KiB 908.20 KiB 884.45 KiB

Base automatically changed from philprime/strict-nullability-2 to main July 29, 2025 07:00
@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Jul 29, 2025
@philprime philprime merged commit 795dd39 into main Jul 29, 2025
134 checks passed
@philprime philprime deleted the philprime/strict-nullability-3 branch July 29, 2025 08:01
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants