-
-
Notifications
You must be signed in to change notification settings - Fork 372
refactor: Add null unwrapping to silence handled nullability warnings #5752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcf28a2 to
64ed63a
Compare
❌ 3 Tests Failed:
View the top 2 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
philipphofmann
approved these changes
Jul 29, 2025
Member
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, when not making these defines public in SentryDefines.h
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4e3915a | 1230.02 ms | 1258.90 ms | 28.88 ms |
| c2982e7 | 1223.92 ms | 1242.86 ms | 18.94 ms |
| 736bcfb | 1229.86 ms | 1249.59 ms | 19.73 ms |
| 2a07609 | 1207.79 ms | 1233.77 ms | 25.98 ms |
| 9add417 | 1224.33 ms | 1243.06 ms | 18.73 ms |
| 2a7868a | 1226.54 ms | 1256.92 ms | 30.37 ms |
| d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
| 42cfd79 | 1222.13 ms | 1244.23 ms | 22.10 ms |
| aa98fe8 | 1227.69 ms | 1253.18 ms | 25.50 ms |
| b714cb9 | 1224.71 ms | 1238.04 ms | 13.33 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4e3915a | 23.75 KiB | 858.69 KiB | 834.94 KiB |
| c2982e7 | 23.75 KiB | 911.62 KiB | 887.87 KiB |
| 736bcfb | 23.74 KiB | 891.02 KiB | 867.28 KiB |
| 2a07609 | 23.75 KiB | 912.78 KiB | 889.03 KiB |
| 9add417 | 23.75 KiB | 908.40 KiB | 884.65 KiB |
| 2a7868a | 23.75 KiB | 880.20 KiB | 856.45 KiB |
| d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 42cfd79 | 23.75 KiB | 880.20 KiB | 856.45 KiB |
| aa98fe8 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
| b714cb9 | 23.75 KiB | 858.69 KiB | 834.93 KiB |
Previous results on branch: philprime/strict-nullability-6
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a6679b1 | 1210.02 ms | 1237.24 ms | 27.22 ms |
| 17eb25b | 1221.06 ms | 1231.31 ms | 10.24 ms |
| 3af5b54 | 1219.20 ms | 1241.34 ms | 22.14 ms |
| 3a0db03 | 1209.72 ms | 1240.47 ms | 30.75 ms |
| f9e69b3 | 1232.48 ms | 1264.38 ms | 31.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a6679b1 | 23.75 KiB | 913.50 KiB | 889.75 KiB |
| 17eb25b | 23.75 KiB | 912.97 KiB | 889.22 KiB |
| 3af5b54 | 23.75 KiB | 912.97 KiB | 889.23 KiB |
| 3a0db03 | 23.75 KiB | 912.57 KiB | 888.82 KiB |
| f9e69b3 | 23.75 KiB | 913.50 KiB | 889.75 KiB |
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
…warnings (getsentry#5752)" This reverts commit 480185d.
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
…warnings (getsentry#5752)" This reverts commit 480185d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Waiting for: CI 🤖
Marks PR as ready-for-merge when CI passes. To be replaced with required checks.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is derived from #5572 in an effort to make the large amount of changes easier to review for #5577.
This PR must be merged after #5777
Adds the macro
SENTRY_UNWRAP_NULLABLEfor already handled cases to silence warnings#skip-changelog