Skip to content

Conversation

@philipphofmann
Copy link
Member

Make the test requirements less strict by removing the assert of the blocking duration and adding a test expectation timing out after 10 seconds to prevent hanging CI if the flush blocks longer.

The test failed here https://github.com/getsentry/sentry-cocoa/actions/runs/16743553141/job/47396825598

Make the test requirements less strict by removing the assert of the
blocking duration and adding a test expectation timing out after 10
seconds to prevent hanging CI if the flush blocks longer.
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 5, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
31825 3 31822 97
View the top 1 failed test(s) by shortest run time
SentryTests.SentryNetworkTrackerIntegrationTests::testGetRequest_SpanCreatedAndBaggageHeaderAdded
Stack Traces | 0s run time
.../Performance/Network/SentryNetworkTrackerIntegrationTests.swift:182 - XCTAssertTrue failed
View the full list of 2 ❄️ flaky tests
iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp

Flake rate in main: 50.00% (Passed 2 times, Failed 2 times)

Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:14 - Failed to get matching snapshots: Timed out while evaluating UI query.
iOS_SwiftUI_UITests.LaunchUITests::testNoNewTransactionForSecondCallToBody

Flake rate in main: 12.50% (Passed 14 times, Failed 2 times)

Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:36 - Failed to tap "Form Screen" Button: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@philipphofmann
Copy link
Member Author

Unrelated unit and ui tests failed. I'm still merging this as a rerun would be a waste of time.

@philipphofmann philipphofmann merged commit 7b08a87 into main Aug 5, 2025
46 of 50 checks passed
@philipphofmann philipphofmann deleted the fix/flaky-testFlush_BlocksCallingThread_TimesOut branch August 5, 2025 15:21
philprime pushed a commit that referenced this pull request Aug 6, 2025
Make the test requirements less strict by removing the assert of the
blocking duration and adding a test expectation timing out after 10
seconds to prevent hanging CI if the flush blocks longer.
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants