Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Sep 1, 2025

📜 Description

This PR migrates the ui-tests.yml workflow to use dorny/paths-filter for conditional execution and introduces a dedicated required check job.

Specifically, it:

  • Adds a run_ui_tests_for_prs filter to .github/file-filters.yml with relevant paths.
  • Removes the on.pull_request.paths filter from ui-tests.yml.
  • Introduces a files-changed job to detect relevant file modifications.
  • Makes the main UI test jobs conditional based on the files-changed output.
  • Adds a ui_tests-required-check job that always runs and acts as the single required check for branch protection, failing if any dependent UI test job fails or is cancelled.

💡 Motivation and Context

This change is part of a larger initiative to migrate all workflows using on.[event].paths filtering to dorny/paths-filter and enforce required checks more effectively. See #5951 for full context.

The goal is to ensure UI tests:

  • Always run for schedule and workflow_dispatch events.
  • Run conditionally for pull requests only when relevant files change, improving CI efficiency.
  • Provide a reliable required check (ui_tests-required-check) that can be used in branch protection rules.

This implementation follows the pattern established in the auto-update-tools workflow and referenced in #5893.

Fixes #6032

💚 How did you test it?

The changes were verified by the assistant against the specified requirements and the auto-update-tools workflow pattern.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog


Open in Cursor Open in Web

Co-authored-by: phil.niedertscheider <phil.niedertscheider@sentry.io>
@cursor
Copy link

cursor bot commented Sep 1, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@philprime philprime marked this pull request as draft September 1, 2025 08:41
@philprime philprime self-assigned this Sep 1, 2025
@philprime philprime changed the title Implement UI tests required check chore(ci): Add required checks job for UI tests Sep 1, 2025
@philprime philprime marked this pull request as ready for review September 1, 2025 08:58
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1212.33 ms 1238.80 ms 26.46 ms
Size 23.75 KiB 933.04 KiB 909.29 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3cdbc22 1231.63 ms 1251.06 ms 19.43 ms
2a9a505 1221.49 ms 1238.49 ms 17.00 ms
884b224 1221.11 ms 1255.88 ms 34.77 ms
4e3915a 1230.02 ms 1258.90 ms 28.88 ms
b9aacb6 1230.42 ms 1251.00 ms 20.58 ms
3ec47ae 1231.02 ms 1256.67 ms 25.65 ms
1fe932f 1231.92 ms 1253.44 ms 21.52 ms
a2a3bfb 1227.94 ms 1261.26 ms 33.32 ms
1339919 1214.82 ms 1238.98 ms 24.16 ms
51b7dd3 1235.06 ms 1258.21 ms 23.15 ms

App size

Revision Plain With Sentry Diff
3cdbc22 23.75 KiB 928.14 KiB 904.40 KiB
2a9a505 23.75 KiB 874.46 KiB 850.71 KiB
884b224 23.75 KiB 879.55 KiB 855.80 KiB
4e3915a 23.75 KiB 858.69 KiB 834.94 KiB
b9aacb6 23.75 KiB 913.64 KiB 889.89 KiB
3ec47ae 23.75 KiB 919.88 KiB 896.13 KiB
1fe932f 23.75 KiB 913.63 KiB 889.88 KiB
a2a3bfb 23.75 KiB 872.67 KiB 848.92 KiB
1339919 23.75 KiB 919.70 KiB 895.95 KiB
51b7dd3 23.75 KiB 913.26 KiB 889.52 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if the UITests are stable enough already, so we can enforce this.

@philprime
Copy link
Member Author

@philipphofmann this PR is only here to add the job so we have it as soon as we get UI tests stable. I do not want them to be enforced.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime merged commit 7bd90de into main Sep 2, 2025
194 of 200 checks passed
@philprime philprime deleted the cursor/implement-ui-tests-required-check-99bf branch September 2, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): Add required checks job for UI tests

4 participants