-
-
Notifications
You must be signed in to change notification settings - Fork 372
chore(ci): Add required checks job for UI tests #6035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: phil.niedertscheider <phil.niedertscheider@sentry.io>
|
Cursor Agent can help with this pull request. Just |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3cdbc22 | 1231.63 ms | 1251.06 ms | 19.43 ms |
| 2a9a505 | 1221.49 ms | 1238.49 ms | 17.00 ms |
| 884b224 | 1221.11 ms | 1255.88 ms | 34.77 ms |
| 4e3915a | 1230.02 ms | 1258.90 ms | 28.88 ms |
| b9aacb6 | 1230.42 ms | 1251.00 ms | 20.58 ms |
| 3ec47ae | 1231.02 ms | 1256.67 ms | 25.65 ms |
| 1fe932f | 1231.92 ms | 1253.44 ms | 21.52 ms |
| a2a3bfb | 1227.94 ms | 1261.26 ms | 33.32 ms |
| 1339919 | 1214.82 ms | 1238.98 ms | 24.16 ms |
| 51b7dd3 | 1235.06 ms | 1258.21 ms | 23.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3cdbc22 | 23.75 KiB | 928.14 KiB | 904.40 KiB |
| 2a9a505 | 23.75 KiB | 874.46 KiB | 850.71 KiB |
| 884b224 | 23.75 KiB | 879.55 KiB | 855.80 KiB |
| 4e3915a | 23.75 KiB | 858.69 KiB | 834.94 KiB |
| b9aacb6 | 23.75 KiB | 913.64 KiB | 889.89 KiB |
| 3ec47ae | 23.75 KiB | 919.88 KiB | 896.13 KiB |
| 1fe932f | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| a2a3bfb | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| 1339919 | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| 51b7dd3 | 23.75 KiB | 913.26 KiB | 889.52 KiB |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if the UITests are stable enough already, so we can enforce this.
|
@philipphofmann this PR is only here to add the job so we have it as soon as we get UI tests stable. I do not want them to be enforced. |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
This PR migrates the
ui-tests.ymlworkflow to usedorny/paths-filterfor conditional execution and introduces a dedicated required check job.Specifically, it:
run_ui_tests_for_prsfilter to.github/file-filters.ymlwith relevant paths.on.pull_request.pathsfilter fromui-tests.yml.files-changedjob to detect relevant file modifications.files-changedoutput.ui_tests-required-checkjob that always runs and acts as the single required check for branch protection, failing if any dependent UI test job fails or is cancelled.💡 Motivation and Context
This change is part of a larger initiative to migrate all workflows using
on.[event].pathsfiltering todorny/paths-filterand enforce required checks more effectively. See #5951 for full context.The goal is to ensure UI tests:
ui_tests-required-check) that can be used in branch protection rules.This implementation follows the pattern established in the
auto-update-toolsworkflow and referenced in #5893.Fixes #6032
💚 How did you test it?
The changes were verified by the assistant against the specified requirements and the
auto-update-toolsworkflow pattern.📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.#skip-changelog