Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 2, 2025

#skip-changelog

Closes #6333

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.295%. Comparing base (09471ff) to head (7700efa).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6332       +/-   ##
=============================================
+ Coverage   86.776%   87.295%   +0.519%     
=============================================
  Files          438       438               
  Lines        37343     37311       -32     
  Branches     17434     17436        +2     
=============================================
+ Hits         32405     32571      +166     
+ Misses        4893      4695      -198     
  Partials        45        45               
Files with missing lines Coverage Δ
Sources/Sentry/SentryAppStartTracker.m 94.871% <100.000%> (-3.385%) ⬇️
Sources/Sentry/SentryAppStartTrackingIntegration.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryOptions.m 97.460% <ø> (-0.024%) ⬇️
Sources/Sentry/SentyOptionsInternal.m 99.683% <ø> (-0.004%) ⬇️
...es/Swift/Helper/SentryEnabledFeaturesBuilder.swift 100.000% <ø> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09471ff...7700efa. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.34 ms 1261.14 ms 27.80 ms
Size 23.75 KiB 989.97 KiB 966.22 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9be5373 1215.92 ms 1239.44 ms 23.52 ms
ea2e54c 1207.78 ms 1218.13 ms 10.35 ms
2a6f451 1212.89 ms 1237.45 ms 24.56 ms
d05d866 1211.78 ms 1230.96 ms 19.18 ms
c122943 1210.94 ms 1233.78 ms 22.84 ms
705b962 1200.92 ms 1222.04 ms 21.13 ms
f43a482 1219.00 ms 1245.56 ms 26.56 ms
cbbc82c 1246.43 ms 1266.13 ms 19.70 ms
fae97e5 1229.20 ms 1256.27 ms 27.06 ms
449d185 1216.31 ms 1251.94 ms 35.62 ms

App size

Revision Plain With Sentry Diff
9be5373 23.75 KiB 866.50 KiB 842.75 KiB
ea2e54c 23.75 KiB 919.70 KiB 895.95 KiB
2a6f451 23.75 KiB 913.13 KiB 889.38 KiB
d05d866 23.75 KiB 878.60 KiB 854.85 KiB
c122943 23.74 KiB 926.65 KiB 902.90 KiB
705b962 23.74 KiB 995.47 KiB 971.73 KiB
f43a482 23.75 KiB 928.16 KiB 904.41 KiB
cbbc82c 23.75 KiB 995.22 KiB 971.47 KiB
fae97e5 23.75 KiB 912.37 KiB 888.62 KiB
449d185 23.75 KiB 980.81 KiB 957.06 KiB

Previous results on branch: removePerfV2Option

Startup times

Revision Plain With Sentry Diff
27ed343 1232.79 ms 1253.78 ms 20.99 ms
9192874 1222.80 ms 1263.94 ms 41.14 ms
842a1b6 1219.00 ms 1250.43 ms 31.43 ms
b69227c 1237.43 ms 1263.36 ms 25.93 ms
0709d39 1222.31 ms 1255.38 ms 33.07 ms
379c3ba 1230.40 ms 1259.40 ms 29.01 ms
0375c14 1211.53 ms 1235.08 ms 23.55 ms

App size

Revision Plain With Sentry Diff
27ed343 23.74 KiB 996.45 KiB 972.70 KiB
9192874 23.74 KiB 994.59 KiB 970.85 KiB
842a1b6 23.74 KiB 994.60 KiB 970.85 KiB
b69227c 23.74 KiB 994.60 KiB 970.86 KiB
0709d39 23.75 KiB 989.97 KiB 966.22 KiB
379c3ba 23.74 KiB 994.60 KiB 970.85 KiB
0375c14 23.74 KiB 994.59 KiB 970.85 KiB

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin force-pushed the removePerfV2Option branch 3 times, most recently from e76a810 to bbb570b Compare October 2, 2025 22:53
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR must have a changelog entry. LGTM, when adding the changed behaviour to the changelog.

@noahsmartin noahsmartin force-pushed the removePerfV2Option branch 2 times, most recently from f25e939 to 282efc3 Compare October 3, 2025 16:34
cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin merged commit 7aaa0b6 into main Oct 4, 2025
231 of 247 checks passed
@noahsmartin noahsmartin deleted the removePerfV2Option branch October 4, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Remove v2 perf option from v9 sdk

3 participants