-
-
Notifications
You must be signed in to change notification settings - Fork 372
ref: Cleanup from dependency container conversion #6485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a108d01 to
49685de
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6485 +/- ##
=============================================
+ Coverage 86.677% 87.016% +0.338%
=============================================
Files 452 453 +1
Lines 37629 37748 +119
Branches 17410 17499 +89
=============================================
+ Hits 32616 32847 +231
+ Misses 4969 4856 -113
- Partials 44 45 +1
... and 22 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
49685de to
45f93b3
Compare
itaybre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
45f93b3 to
4bf7c8a
Compare
4bf7c8a to
b8a6932
Compare
b8a6932 to
2ea8f5a
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d157d83 | 1228.02 ms | 1252.47 ms | 24.45 ms |
| 1fecbb8 | 1242.78 ms | 1265.40 ms | 22.62 ms |
| 0529194 | 1237.23 ms | 1254.67 ms | 17.44 ms |
| 354b020 | 1223.88 ms | 1236.82 ms | 12.94 ms |
| d3f650a | 1225.45 ms | 1241.86 ms | 16.41 ms |
| 3ec47ae | 1231.02 ms | 1256.67 ms | 25.65 ms |
| e0e5391 | 1191.21 ms | 1243.14 ms | 51.93 ms |
| 0309548 | 1225.04 ms | 1252.82 ms | 27.77 ms |
| 5cfc768 | 1220.74 ms | 1245.06 ms | 24.32 ms |
| 664c060 | 1215.48 ms | 1244.41 ms | 28.93 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d157d83 | 23.75 KiB | 928.85 KiB | 905.10 KiB |
| 1fecbb8 | 23.75 KiB | 969.28 KiB | 945.53 KiB |
| 0529194 | 23.74 KiB | 891.02 KiB | 867.28 KiB |
| 354b020 | 23.75 KiB | 878.19 KiB | 854.44 KiB |
| d3f650a | 23.75 KiB | 902.48 KiB | 878.73 KiB |
| 3ec47ae | 23.75 KiB | 919.88 KiB | 896.13 KiB |
| e0e5391 | 23.74 KiB | 1022.21 KiB | 998.46 KiB |
| 0309548 | 23.75 KiB | 994.74 KiB | 970.99 KiB |
| 5cfc768 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 664c060 | 23.74 KiB | 977.41 KiB | 953.67 KiB |
This can all be cleaned up now that the dependency container is in Swift
#skip-changelog
Closes #6486