Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 21, 2025

This can all be cleaned up now that the dependency container is in Swift

#skip-changelog

Closes #6486

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.016%. Comparing base (0bef3a6) to head (2ea8f5a).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Swift/SentryCrash/SentryCrashWrapper.swift 66.666% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6485       +/-   ##
=============================================
+ Coverage   86.677%   87.016%   +0.338%     
=============================================
  Files          452       453        +1     
  Lines        37629     37748      +119     
  Branches     17410     17499       +89     
=============================================
+ Hits         32616     32847      +231     
+ Misses        4969      4856      -113     
- Partials        44        45        +1     
Files with missing lines Coverage Δ
...tryTestUtils/SentryProfilerMocksSwiftCompatible.mm 100.000% <ø> (ø)
Sources/Sentry/PrivateSentrySDKOnly.m 25.000% <ø> (ø)
...ors/SentryWatchdogTerminationBreadcrumbProcessor.m 98.648% <ø> (ø)
Sources/Sentry/Profiling/SentryLaunchProfiling.m 81.884% <ø> (ø)
...entry/Profiling/SentryProfiledTracerConcurrency.mm 90.661% <ø> (-0.390%) ⬇️
...ces/Sentry/Profiling/SentryProfilerSerialization.m 86.219% <ø> (-2.121%) ⬇️
...ces/Sentry/Profiling/SentryProfilingSwiftHelpers.m 96.969% <ø> (ø)
Sources/Sentry/SentryANRTrackerV1.m 93.893% <ø> (ø)
Sources/Sentry/SentryANRTrackerV2.m 98.895% <ø> (ø)
Sources/Sentry/SentryANRTrackingIntegration.m 96.710% <ø> (ø)
... and 49 more

... and 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bef3a6...2ea8f5a. Read the comment docs.

@noahsmartin noahsmartin force-pushed the dependencyContainerCleanup branch from 49685de to 45f93b3 Compare October 21, 2025 18:54
Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin force-pushed the dependencyContainerCleanup branch from 45f93b3 to 4bf7c8a Compare October 21, 2025 18:57
cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin force-pushed the dependencyContainerCleanup branch from 4bf7c8a to b8a6932 Compare October 21, 2025 19:00
@noahsmartin noahsmartin force-pushed the dependencyContainerCleanup branch from b8a6932 to 2ea8f5a Compare October 21, 2025 19:05
@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryUIViewControllerSwizzling.m

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.90 ms 1266.11 ms 33.22 ms
Size 23.74 KiB 1.01 MiB 1008.99 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d157d83 1228.02 ms 1252.47 ms 24.45 ms
1fecbb8 1242.78 ms 1265.40 ms 22.62 ms
0529194 1237.23 ms 1254.67 ms 17.44 ms
354b020 1223.88 ms 1236.82 ms 12.94 ms
d3f650a 1225.45 ms 1241.86 ms 16.41 ms
3ec47ae 1231.02 ms 1256.67 ms 25.65 ms
e0e5391 1191.21 ms 1243.14 ms 51.93 ms
0309548 1225.04 ms 1252.82 ms 27.77 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms
664c060 1215.48 ms 1244.41 ms 28.93 ms

App size

Revision Plain With Sentry Diff
d157d83 23.75 KiB 928.85 KiB 905.10 KiB
1fecbb8 23.75 KiB 969.28 KiB 945.53 KiB
0529194 23.74 KiB 891.02 KiB 867.28 KiB
354b020 23.75 KiB 878.19 KiB 854.44 KiB
d3f650a 23.75 KiB 902.48 KiB 878.73 KiB
3ec47ae 23.75 KiB 919.88 KiB 896.13 KiB
e0e5391 23.74 KiB 1022.21 KiB 998.46 KiB
0309548 23.75 KiB 994.74 KiB 970.99 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB
664c060 23.74 KiB 977.41 KiB 953.67 KiB

@noahsmartin noahsmartin merged commit 66147d5 into main Oct 21, 2025
187 of 194 checks passed
@noahsmartin noahsmartin deleted the dependencyContainerCleanup branch October 21, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Cleanup from dependency container conversion

3 participants