-
-
Notifications
You must be signed in to change notification settings - Fork 372
test: Adjust data count range in SpotlightTests #6549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the expected data count range in the SentrySpotlightTransportTests to allow for a wider variance in GZip compression results, changing the lower and upper bounds from ±20 to ±40 to avoid flakiness.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6549 +/- ##
========================================
Coverage ? 86.311%
========================================
Files ? 451
Lines ? 37191
Branches ? 17205
========================================
Hits ? 32100
Misses ? 4808
Partials ? 283 Continue to review full report in Codecov by Sentry.
|
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but to be honest this is a wide range and it seems that this test highly unstable. We might want to explore if GZip can be configured to be deterministic
True, but honestly, I don't want to invest that time right now for Spotlight. I don't think many people are using it. At least I can't remember a user opening an issue or asking questions about it. |
|
I was even thinking about suggesting we remove the tests of Spotlight instead of fixing them. |
Yes, me too. We can ditch this single test case if it still breaks in the future. |
Updated the expected data count range in the
SentrySpotlightTransportTests to allow for a wider variance in GZip compression results, changing the lower and upper bounds from ±20 to ±40 to avoid flakiness.
Test failed here https://github.com/getsentry/sentry-cocoa/actions/runs/18778698663/job/53579222897.
#skip-changelog
Closes #6550