-
-
Notifications
You must be signed in to change notification settings - Fork 372
fix: Accessing SentryLevel from ObjC types #6802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c9a8f3 to
da63814
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6802 +/- ##
========================================
Coverage ? 84.892%
========================================
Files ? 452
Lines ? 27603
Branches ? 12103
========================================
Hits ? 23433
Misses ? 4125
Partials ? 45
Continue to review full report in Codecov by Sentry.
|
a350e8c to
b63a89d
Compare
Sources/Swift/Integrations/SessionReplay/SentrySRDefaultBreadcrumbConverter.swift
Show resolved
Hide resolved
b63a89d to
a7f47ab
Compare
83619cc to
095778a
Compare
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee1f2ca | 1227.47 ms | 1251.58 ms | 24.12 ms |
| 0759f32 | 1237.10 ms | 1257.35 ms | 20.25 ms |
| 11853e6 | 1220.37 ms | 1252.83 ms | 32.46 ms |
| c6c1cb7 | 1235.71 ms | 1263.80 ms | 28.08 ms |
| 7bd90de | 1233.48 ms | 1249.47 ms | 15.99 ms |
| b9ceffb | 1222.57 ms | 1247.96 ms | 25.39 ms |
| 2fc1ea5 | 1236.23 ms | 1246.79 ms | 10.56 ms |
| 837f5e4 | 1231.20 ms | 1265.47 ms | 34.27 ms |
| cd9727b | 1236.04 ms | 1254.41 ms | 18.37 ms |
| debf3e9 | 1227.45 ms | 1235.71 ms | 8.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee1f2ca | 24.15 KiB | 1.01 MiB | 1015.24 KiB |
| 0759f32 | 23.75 KiB | 880.20 KiB | 856.46 KiB |
| 11853e6 | 23.75 KiB | 1.01 MiB | 1016.04 KiB |
| c6c1cb7 | 23.75 KiB | 928.15 KiB | 904.40 KiB |
| 7bd90de | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| b9ceffb | 23.75 KiB | 969.07 KiB | 945.32 KiB |
| 2fc1ea5 | 23.75 KiB | 1.02 MiB | 1016.53 KiB |
| 837f5e4 | 23.75 KiB | 1.01 MiB | 1016.25 KiB |
| cd9727b | 23.75 KiB | 879.25 KiB | 855.51 KiB |
| debf3e9 | 23.75 KiB | 1.01 MiB | 1006.46 KiB |
Previous results on branch: levelObjC
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 434cc52 | 1229.17 ms | 1262.29 ms | 33.12 ms |
| 8ec6696 | 1228.13 ms | 1259.16 ms | 31.03 ms |
| 597a8fa | 1233.42 ms | 1260.57 ms | 27.15 ms |
| 4510327 | 1232.64 ms | 1264.65 ms | 32.01 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 434cc52 | 24.15 KiB | 1.01 MiB | 1014.59 KiB |
| 8ec6696 | 24.15 KiB | 1.01 MiB | 1014.59 KiB |
| 597a8fa | 24.15 KiB | 1.01 MiB | 1014.59 KiB |
| 4510327 | 24.15 KiB | 1.01 MiB | 1014.60 KiB |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
095778a to
7e13b76
Compare
|
@philipphofmann thanks for taking a look, rebased and addressed those comments |
b40aa10 to
3a8ac97
Compare
3a8ac97 to
f9cb39d
Compare
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes accessing the Breadcrumb constructor from SPM since it was using this type defined in Swift. Similar to how I changed SentryId to be in ObjC. This also removes the need for a bunch of this wrapper code
#skip-changelog
Closes #6803