Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Nov 17, 2025

Fixes accessing the Breadcrumb constructor from SPM since it was using this type defined in Swift. Similar to how I changed SentryId to be in ObjC. This also removes the need for a bunch of this wrapper code

#skip-changelog

Closes #6803

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@095d886). Learn more about missing BASE report.
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6802   +/-   ##
========================================
  Coverage        ?   84.892%           
========================================
  Files           ?       452           
  Lines           ?     27603           
  Branches        ?     12103           
========================================
  Hits            ?     23433           
  Misses          ?      4125           
  Partials        ?        45           
Files with missing lines Coverage Δ
Sources/Sentry/SentryBreadcrumb.m 97.530% <ø> (ø)
Sources/Sentry/SentryEvent.m 98.979% <ø> (ø)
Sources/Sentry/SentryScope.m 96.875% <ø> (ø)
Sources/Sentry/SentrySessionReplayIntegration.m 85.930% <ø> (ø)
Sources/Swift/Core/Helper/Log/SentryLevel.swift 100.000% <100.000%> (ø)
...ssionReplay/RRWeb/SentryRRWebBreadcrumbEvent.swift 100.000% <100.000%> (ø)
...ionReplay/SentrySRDefaultBreadcrumbConverter.swift 98.113% <100.000%> (ø)
...ift/Protocol/Codable/SentryBreadcrumbCodable.swift 100.000% <100.000%> (ø)
...es/Swift/Protocol/Codable/SentryEventCodable.swift 100.000% <100.000%> (ø)
Sources/Swift/Tools/SentryEnvelopeItem.swift 88.073% <100.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 095d886...f9cb39d. Read the comment docs.

@noahsmartin noahsmartin force-pushed the levelObjC branch 2 times, most recently from a350e8c to b63a89d Compare November 17, 2025 16:35
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.80 ms 1245.74 ms 30.94 ms
Size 24.15 KiB 1.01 MiB 1014.60 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ee1f2ca 1227.47 ms 1251.58 ms 24.12 ms
0759f32 1237.10 ms 1257.35 ms 20.25 ms
11853e6 1220.37 ms 1252.83 ms 32.46 ms
c6c1cb7 1235.71 ms 1263.80 ms 28.08 ms
7bd90de 1233.48 ms 1249.47 ms 15.99 ms
b9ceffb 1222.57 ms 1247.96 ms 25.39 ms
2fc1ea5 1236.23 ms 1246.79 ms 10.56 ms
837f5e4 1231.20 ms 1265.47 ms 34.27 ms
cd9727b 1236.04 ms 1254.41 ms 18.37 ms
debf3e9 1227.45 ms 1235.71 ms 8.26 ms

App size

Revision Plain With Sentry Diff
ee1f2ca 24.15 KiB 1.01 MiB 1015.24 KiB
0759f32 23.75 KiB 880.20 KiB 856.46 KiB
11853e6 23.75 KiB 1.01 MiB 1016.04 KiB
c6c1cb7 23.75 KiB 928.15 KiB 904.40 KiB
7bd90de 23.75 KiB 933.33 KiB 909.58 KiB
b9ceffb 23.75 KiB 969.07 KiB 945.32 KiB
2fc1ea5 23.75 KiB 1.02 MiB 1016.53 KiB
837f5e4 23.75 KiB 1.01 MiB 1016.25 KiB
cd9727b 23.75 KiB 879.25 KiB 855.51 KiB
debf3e9 23.75 KiB 1.01 MiB 1006.46 KiB

Previous results on branch: levelObjC

Startup times

Revision Plain With Sentry Diff
434cc52 1229.17 ms 1262.29 ms 33.12 ms
8ec6696 1228.13 ms 1259.16 ms 31.03 ms
597a8fa 1233.42 ms 1260.57 ms 27.15 ms
4510327 1232.64 ms 1264.65 ms 32.01 ms

App size

Revision Plain With Sentry Diff
434cc52 24.15 KiB 1.01 MiB 1014.59 KiB
8ec6696 24.15 KiB 1.01 MiB 1014.59 KiB
597a8fa 24.15 KiB 1.01 MiB 1014.59 KiB
4510327 24.15 KiB 1.01 MiB 1014.60 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

@noahsmartin
Copy link
Contributor Author

@philipphofmann thanks for taking a look, rebased and addressed those comments

@noahsmartin noahsmartin force-pushed the levelObjC branch 2 times, most recently from b40aa10 to 3a8ac97 Compare November 18, 2025 18:08
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin merged commit f0d57ae into main Nov 19, 2025
215 of 223 checks passed
@noahsmartin noahsmartin deleted the levelObjC branch November 19, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Accessing SentryLevel from ObjC types

4 participants