-
-
Notifications
You must be signed in to change notification settings - Fork 372
ref: Use Swift integrations #6862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ddc979e to
979af12
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6862 +/- ##
=============================================
+ Coverage 84.650% 84.668% +0.018%
=============================================
Files 452 453 +1
Lines 27603 27617 +14
Branches 12098 12112 +14
=============================================
+ Hits 23366 23383 +17
+ Misses 4191 4188 -3
Partials 46 46
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
b0d6dfe to
4a01fe6
Compare
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1339919 | 1214.82 ms | 1238.98 ms | 24.16 ms |
| 319fb1e | 1219.48 ms | 1242.69 ms | 23.21 ms |
| 3ec47ae | 1231.02 ms | 1256.67 ms | 25.65 ms |
| e58d7bf | 1219.98 ms | 1242.39 ms | 22.41 ms |
| 85f7349 | 1232.28 ms | 1248.27 ms | 15.98 ms |
| 7f26f16 | 1220.62 ms | 1255.04 ms | 34.42 ms |
| 119ab1c | 1226.79 ms | 1254.55 ms | 27.76 ms |
| 1fe932f | 1231.92 ms | 1253.44 ms | 21.52 ms |
| 139db8b | 1231.50 ms | 1258.19 ms | 26.69 ms |
| a4c5ddc | 1239.61 ms | 1266.41 ms | 26.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1339919 | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| 319fb1e | 23.75 KiB | 1019.18 KiB | 995.43 KiB |
| 3ec47ae | 23.75 KiB | 919.88 KiB | 896.13 KiB |
| e58d7bf | 24.15 KiB | 1.01 MiB | 1014.91 KiB |
| 85f7349 | 23.75 KiB | 1.01 MiB | 1006.48 KiB |
| 7f26f16 | 23.75 KiB | 1.02 MiB | 1016.66 KiB |
| 119ab1c | 23.75 KiB | 993.70 KiB | 969.95 KiB |
| 1fe932f | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| 139db8b | 23.75 KiB | 920.64 KiB | 896.89 KiB |
| a4c5ddc | 23.75 KiB | 977.30 KiB | 953.55 KiB |
a35d333 to
10b2476
Compare
| @property (nullable, nonatomic, strong) SentrySession *session; | ||
|
|
||
| @property (nonatomic, strong) NSMutableArray<id<SentryIntegrationProtocol>> *installedIntegrations; | ||
| @property (nonatomic, strong) NSMutableArray<id> *installedIntegrations; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new version of this protocol is not accessible to ObjC, but as far as I can tell the fact this was previously SentryIntegrationProtocol wasn't important so it can just be replaced with id
10b2476 to
4a2d481
Compare
Adds a new protocol for integrations that takes dependencies as an input. For the easiest migration conformers of the protocol can satisfy the
Dependenciesassociated type with justtypealias Dependencies = SentryDependencyContainer. This PR shows how it can be used to make the dependencies just define the minimum necessary dependencies so it can be easily mocked in tests.#skip-changelog
Closes #6863