Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Nov 20, 2025

Just converts this class to Swift. I'll get rid of the wrapper in a follow up PR after converting the Integration class to Swift

#skip-changelog

Closes #6865

@noahsmartin noahsmartin added the ready-to-merge Use this label to trigger all PR workflows label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.840%. Comparing base (5fcb6a1) to head (02a1c4e).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../Integrations/UserFeedback/SentryFeedbackAPI.swift 0.000% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6864       +/-   ##
=============================================
+ Coverage   84.650%   84.840%   +0.190%     
=============================================
  Files          452       453        +1     
  Lines        27603     27607        +4     
  Branches     12098     12103        +5     
=============================================
+ Hits         23366     23422       +56     
+ Misses        4191      4141       -50     
+ Partials        46        44        -2     
Files with missing lines Coverage Δ
Sources/Sentry/SentryFeedbackAPIHelper.m 0.000% <ø> (ø)
Sources/Sentry/SentrySDKInternal.m 85.140% <ø> (ø)
.../Integrations/UserFeedback/SentryFeedbackAPI.swift 0.000% <0.000%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fcb6a1...02a1c4e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.06 ms 1245.46 ms 32.40 ms
Size 24.14 KiB 1.01 MiB 1014.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1339919 1214.82 ms 1238.98 ms 24.16 ms
319fb1e 1219.48 ms 1242.69 ms 23.21 ms
3ec47ae 1231.02 ms 1256.67 ms 25.65 ms
e58d7bf 1219.98 ms 1242.39 ms 22.41 ms
85f7349 1232.28 ms 1248.27 ms 15.98 ms
7f26f16 1220.62 ms 1255.04 ms 34.42 ms
119ab1c 1226.79 ms 1254.55 ms 27.76 ms
1fe932f 1231.92 ms 1253.44 ms 21.52 ms
139db8b 1231.50 ms 1258.19 ms 26.69 ms
a4c5ddc 1239.61 ms 1266.41 ms 26.80 ms

App size

Revision Plain With Sentry Diff
1339919 23.75 KiB 919.70 KiB 895.95 KiB
319fb1e 23.75 KiB 1019.18 KiB 995.43 KiB
3ec47ae 23.75 KiB 919.88 KiB 896.13 KiB
e58d7bf 24.15 KiB 1.01 MiB 1014.91 KiB
85f7349 23.75 KiB 1.01 MiB 1006.48 KiB
7f26f16 23.75 KiB 1.02 MiB 1016.66 KiB
119ab1c 23.75 KiB 993.70 KiB 969.95 KiB
1fe932f 23.75 KiB 913.63 KiB 889.88 KiB
139db8b 23.75 KiB 920.64 KiB 896.89 KiB
a4c5ddc 23.75 KiB 977.30 KiB 953.55 KiB

Previous results on branch: updatePublicSwift

Startup times

Revision Plain With Sentry Diff
02fb0d7 1220.43 ms 1255.98 ms 35.55 ms

App size

Revision Plain With Sentry Diff
02fb0d7 24.14 KiB 1.01 MiB 1014.98 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Convert SentryFeedbackAPI to Swift

2 participants