Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Add read-only scope property to Hub #975

Merged
merged 3 commits into from
Mar 4, 2021
Merged

ref: Add read-only scope property to Hub #975

merged 3 commits into from
Mar 4, 2021

Conversation

philipphofmann
Copy link
Member

📜 Description

Add read-only property for scope to Hub and mark getScope as deprecated.

💡 Motivation and Context

Simplify the API.

💚 How did you test it?

CI and unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the CHANGELOG if needed
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

@philipphofmann
feat: Add read-only scope property to Hub
2c9f70e 
Add read only property for scope to Hub and mark getScope as deprecated.
@philipphofmann philipphofmann added this to the 7.0.0 milestone Mar 3, 2021
@philipphofmann philipphofmann requested a review from a team March 3, 2021 13:45
@philipphofmann philipphofmann self-assigned this Mar 3, 2021
bruno-garcia
bruno-garcia approved these changes Mar 3, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@philipphofmann philipphofmann changed the title feat: Add read-only scope property to Hub ref: Add read-only scope property to Hub Mar 4, 2021
philipphofmann and others added 2 commits March 4, 2021 09:18
@philipphofmann @bruno-garcia
Update CHANGELOG.md
ab2b110 
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@philipphofmann
Merge branch 'master' into feat/hub-scope-property
bc81852
@philipphofmann philipphofmann enabled auto-merge (squash) March 4, 2021 08:32
@philipphofmann philipphofmann merged commit 769e2f0 into master Mar 4, 2021
@philipphofmann philipphofmann deleted the feat/hub-scope-property branch March 4, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@marandaneto marandaneto marandaneto approved these changes

Assignees

@philipphofmann philipphofmann

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@philipphofmann @bruno-garcia @marandaneto