Skip to content

add domain checker #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add domain checker #32

wants to merge 2 commits into from

Conversation

marandaneto
Copy link
Contributor

#skip-changelog

The goal of this draft PR is to do this: dart-lang/pub#3307 (comment)

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

@marandaneto
Copy link
Contributor Author

@philipphofmann this is not intended to be merged, the class is copied from the Dart SDK.
It's just a repro case for the Dart team, See PR description.
Thanks for the review anyway.

@marandaneto marandaneto deleted the test/domain branch October 14, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants