add platform to stacktrace

getsentry · Jul 23, 2024 · 6467789 · 6467789
1 parent 7770462
commit 6467789
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/dart/lib/src/sentry_stack_trace_factory.dart b/dart/lib/src/sentry_stack_trace_factory.dart
@@ -125,6 +125,12 @@ class SentryStackTraceFactory {
     if (column != null && column >= 0) {
       sentryStackFrame = sentryStackFrame.copyWith(colNo: frame.column);
     }
+
+    if (sentryStackFrame.platform == null) {
+      sentryStackFrame = sentryStackFrame.copyWith(
+          platform: sentryStackFrame.platform ??
+              (_options.platformChecker.isWeb ? 'javascript' : 'dart'));
+    }
     return sentryStackFrame;
   }
 

diff --git a/dart/test/stack_trace_test.dart b/dart/test/stack_trace_test.dart
@@ -9,6 +9,7 @@ import 'package:stack_trace/stack_trace.dart';
 import 'package:test/test.dart';
 
 import 'mocks.dart';
+import 'mocks/mock_platform_checker.dart';
 
 void main() {
   group('encodeStackTraceFrame', () {
@@ -258,6 +259,29 @@ isolate_instructions: 10fa27070, vm_instructions: 10fa21e20
           .map((frame) => frame.toJson());
       expect(frames.isEmpty, true);
     });
+
+    test('sets platform to javascript for web and dart for non-web', () {
+      final frame = Frame(Uri.parse('file://foo/bar/baz.dart'), 1, 2, 'buzz');
+      final fixture = Fixture();
+
+      // Test for web platform
+      final webSut = fixture.getSut(isWeb: true);
+      var webFrame = webSut.encodeStackTraceFrame(frame)!;
+      expect(webFrame.platform, 'javascript');
+
+      // Test for non-web platform
+      final nativeFrameBeforeSut = fixture.getSut(isWeb: false);
+      var nativeFrameBefore =
+          nativeFrameBeforeSut.encodeStackTraceFrame(frame)!;
+      expect(nativeFrameBefore.platform, 'dart');
+
+      // Test when platform is already set
+      final frameWithPlatform = fixture
+          .getSut()
+          .encodeStackTraceFrame(frame)!
+          .copyWith(platform: 'native');
+      expect(frameWithPlatform.platform, 'native');
+    });
   });
 }
 
@@ -266,8 +290,10 @@ class Fixture {
     List<String> inAppIncludes = const [],
     List<String> inAppExcludes = const [],
     bool considerInAppFramesByDefault = true,
+    bool isWeb = false,
   }) {
-    final options = SentryOptions(dsn: fakeDsn);
+    final options = SentryOptions(
+        dsn: fakeDsn, checker: MockPlatformChecker(isWebValue: isWeb));
     inAppIncludes.forEach(options.addInAppInclude);
     inAppExcludes.forEach(options.addInAppExclude);
     options.considerInAppFramesByDefault = considerInAppFramesByDefault;