Fix battery level convertion for iOS 16.4 (#1433)

getsentry · May 10, 2023 · bf4aed7 · bf4aed7
1 parent 3a43905
commit bf4aed7
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Fixes
 
+- Fix battery level convertion for iOS 16.4 ([#1433](https://github.com/getsentry/sentry-dart/pull/1433))
 - Adds a namespace for compatibility with AGP 8.0. ([#1427](https://github.com/getsentry/sentry-dart/pull/1427))
 
 ## 7.5.2

diff --git a/dart/lib/src/protocol/sentry_device.dart b/dart/lib/src/protocol/sentry_device.dart
@@ -178,7 +178,9 @@ class SentryDevice {
         model: data['model'],
         modelId: data['model_id'],
         arch: data['arch'],
-        batteryLevel: data['battery_level'],
+        batteryLevel:
+            (data['battery_level'] is num ? data['battery_level'] as num : null)
+                ?.toDouble(),
         orientation: data['orientation'] == 'portrait'
             ? SentryOrientation.portrait
             : data['orientation'] == 'landscape'

diff --git a/dart/test/protocol/sentry_device_test.dart b/dart/test/protocol/sentry_device_test.dart
@@ -115,6 +115,39 @@ void main() {
         true,
       );
     });
+
+    test('batery level converts int to double', () {
+      final map = {'battery_level': 1};
+
+      final sentryDevice = SentryDevice.fromJson(map);
+
+      expect(
+        sentryDevice.batteryLevel,
+        1.0,
+      );
+    });
+
+    test('batery level maps double', () {
+      final map = {'battery_level': 1.0};
+
+      final sentryDevice = SentryDevice.fromJson(map);
+
+      expect(
+        sentryDevice.batteryLevel,
+        1.0,
+      );
+    });
+
+    test('batery level ignores if not a num', () {
+      final map = {'battery_level': 'abc'};
+
+      final sentryDevice = SentryDevice.fromJson(map);
+
+      expect(
+        sentryDevice.batteryLevel,
+        null,
+      );
+    });
   });
 
   group('copyWith', () {