-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint issues #1067
Merged
Merged
Fix lint issues #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
af2d175 | 279.08 ms | 312.37 ms | 33.29 ms |
3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
1c6eb5b | 350.69 ms | 393.86 ms | 43.17 ms |
9c5aec6 | 287.33 ms | 320.94 ms | 33.61 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
af2d175 | 5.94 MiB | 6.92 MiB | 1001.83 KiB |
3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
1c6eb5b | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
9c5aec6 | 5.94 MiB | 6.92 MiB | 1001.61 KiB |
Codecov ReportBase: 90.45% // Head: 91.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1067 +/- ##
==========================================
+ Coverage 90.45% 91.37% +0.91%
==========================================
Files 114 9 -105
Lines 3584 197 -3387
==========================================
- Hits 3242 180 -3062
+ Misses 342 17 -325 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3e5ee37 | 1248.25 ms | 1265.38 ms | 17.13 ms |
af2d175 | 1280.37 ms | 1282.24 ms | 1.88 ms |
1c6eb5b | 1277.85 ms | 1285.71 ms | 7.86 ms |
9c5aec6 | 1266.51 ms | 1274.65 ms | 8.14 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3e5ee37 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
af2d175 | 8.15 MiB | 9.12 MiB | 986.22 KiB |
1c6eb5b | 8.15 MiB | 9.12 MiB | 986.27 KiB |
9c5aec6 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
October 11, 2022 08:16
brustolin
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Lint will throw if there are warnings
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps