Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issues #1067

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Fix lint issues #1067

merged 2 commits into from
Oct 11, 2022

Conversation

marandaneto
Copy link
Contributor

📜 Description

Lint will throw if there are warnings
#skip-changelog

💡 Motivation and Context

Line Length Violation: Line should be 120 characters or less: currently 124 characters (line_length)

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 326.62 ms 382.09 ms 55.47 ms
Size 5.94 MiB 6.92 MiB 1001.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
af2d175 279.08 ms 312.37 ms 33.29 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms
9c5aec6 287.33 ms 320.94 ms 33.61 ms

App size

Revision Plain With Sentry Diff
af2d175 5.94 MiB 6.92 MiB 1001.83 KiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB
9c5aec6 5.94 MiB 6.92 MiB 1001.61 KiB

Previous results on branch: fix/lint-issues

Startup times

Revision Plain With Sentry Diff
ab89000 308.98 ms 352.25 ms 43.27 ms

App size

Revision Plain With Sentry Diff
ab89000 5.94 MiB 6.92 MiB 1001.54 KiB

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 90.45% // Head: 91.37% // Increases project coverage by +0.91% 🎉

Coverage data is based on head (0f0f1e1) compared to base (9c5aec6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
+ Coverage   90.45%   91.37%   +0.91%     
==========================================
  Files         114        9     -105     
  Lines        3584      197    -3387     
==========================================
- Hits         3242      180    -3062     
+ Misses        342       17     -325     
Impacted Files Coverage Δ
dart/lib/src/version.dart
dart/lib/src/sentry_measurement_unit.dart
dart/lib/src/sentry_tracer_finish_status.dart
dart/lib/src/protocol/sentry_message.dart
dart/lib/src/protocol/sentry_stack_trace.dart
dart/lib/src/diagnostic_logger.dart
dart/lib/src/http_client/tracing_client.dart
dart/lib/src/sentry_exception_factory.dart
dart/lib/src/transport/encode.dart
dart/lib/src/sentry_user_feedback.dart
... and 95 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1288.59 ms 1302.88 ms 14.29 ms
Size 8.15 MiB 9.12 MiB 986.29 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3e5ee37 1248.25 ms 1265.38 ms 17.13 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
1c6eb5b 1277.85 ms 1285.71 ms 7.86 ms
9c5aec6 1266.51 ms 1274.65 ms 8.14 ms

App size

Revision Plain With Sentry Diff
3e5ee37 8.15 MiB 9.12 MiB 986.23 KiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
1c6eb5b 8.15 MiB 9.12 MiB 986.27 KiB
9c5aec6 8.15 MiB 9.12 MiB 986.23 KiB

Previous results on branch: fix/lint-issues

Startup times

Revision Plain With Sentry Diff
ab89000 1255.08 ms 1271.67 ms 16.59 ms

App size

Revision Plain With Sentry Diff
ab89000 8.15 MiB 9.12 MiB 986.24 KiB

@marandaneto marandaneto mentioned this pull request Oct 11, 2022
5 tasks
@marandaneto marandaneto marked this pull request as ready for review October 11, 2022 08:16
@marandaneto marandaneto merged commit 633cf2e into main Oct 11, 2022
@marandaneto marandaneto deleted the fix/lint-issues branch October 11, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants