Update dependency `intl` to ^0.18.0 #1202

zeshuaro · 2022-12-21T11:31:34Z

📜 Description

Update dependency intl to ^0.18.0 - https://pub.dev/packages/intl.

💡 Motivation and Context

My project uses both sentry and intl. Right now, I'm unable to upgrade intl to ^0.18.0 in my project because sentry depends on intl: ^0.17.0 and the version resolution would fail.

💚 How did you test it?

Hoping GitHub Actions will verify that the new version of intl is still compatible.

📝 Checklist

🔮 Next steps

marandaneto · 2022-12-21T12:47:51Z

@zeshuaro why is it not possible? Sentry uses the ^ operator, so it should be fine to use the latest version as well.
Can you link us the error and why?

zeshuaro · 2022-12-21T12:52:45Z

This is the error I'm getting, you can also see the build here.

Because no versions of sentry_flutter match >6.18.1 <7.0.0 and sentry_flutter >=6.18.0 <6.18.1 depends on sentry 6.18.0, sentry_flutter >=6.18.0 <6.18.1-∞ or >6.18.1 <7.0.0 requires sentry 6.18.0.
And because sentry >=6.11.0 depends on intl ^0.17.0, sentry_flutter >=6.18.0 <6.18.1-∞ or >6.18.1 <7.0.0 requires intl ^0.17.0.
And because sentry_flutter 6.18.1 depends on sentry 6.18.1 which depends on intl ^0.17.0, sentry_flutter ^6.18.0 requires intl ^0.17.0.
So, because appainter depends on both intl ^0.18.0 and sentry_flutter ^6.18.0, version solving failed.

My guess is that Pub classifies minor bumps in versions 0.x.x as breaking change, so it's not able to resolve the latest version of intl.

codecov-commenter · 2022-12-21T12:53:32Z

Codecov Report

Base: 90.03% // Head: 88.87% // Decreases project coverage by -1.16% ⚠️

Coverage data is based on head (b47429d) compared to base (a094100).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   90.03%   88.87%   -1.17%     
==========================================
  Files         110      121      +11     
  Lines        3483     3810     +327     
==========================================
+ Hits         3136     3386     +250     
- Misses        347      424      +77

Impacted Files	Coverage Δ
dio/lib/src/breadcrumb_client_adapter.dart	`80.00% <0.00%> (ø)`
dio/lib/src/failed_request_interceptor.dart	`100.00% <0.00%> (ø)`
dio/lib/src/sentry_transformer.dart	`94.44% <0.00%> (ø)`
dio/lib/src/tracing_client_adapter.dart	`85.71% <0.00%> (ø)`
logging/lib/src/extension.dart	`100.00% <0.00%> (ø)`
dio/lib/src/sentry_dio_extension.dart	`76.92% <0.00%> (ø)`
file/lib/src/sentry_file_extension.dart	`80.00% <0.00%> (ø)`
logging/lib/src/logging_integration.dart	`90.47% <0.00%> (ø)`
file/lib/src/sentry_file.dart	`54.13% <0.00%> (ø)`
dio/lib/src/sentry_dio_client_adapter.dart	`100.00% <0.00%> (ø)`
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ueman · 2022-12-21T12:55:45Z

dart/pubspec.yaml

@@ -15,7 +15,7 @@ dependencies:
  meta: ^1.3.0
  stack_trace: ^1.10.0
  uuid: ^3.0.0
-  intl: ^0.17.0
+  intl: ^0.18.0


There doesn't seem to be a breaking change: https://pub.dev/packages/intl/changelog

Suggested change

intl: ^0.18.0

intl: '>=0.17.0 <0.19.0'

I'm not suggesting the package has breaking changes, I was guessing that Pub treats minor bumps in versions 0.x.x as breaking, which does seem to be the case from here:

Although semantic versioning doesn’t promise any compatibility between versions prior to 1.0.0, the Dart community convention is to treat those versions semantically as well. The interpretation of each number is just shifted down one slot: going from 0.1.2 to 0.2.0 indicates a breaking change, going to 0.1.3 indicates a new feature, and going to 0.1.2+1 indicates a change that doesn’t affect the public API.

That's strange because intl 0.17.0 (0.18.0 available)
it's a minor version but requires dart pub upgrade --major-versions.
Likely a bug in pub?
The suggestion won't work either because sentry won't be compatible with 0.19.0 once is released.

Likely related to flutter/flutter#117163

Tag 0.18.0 is not created yet in the intl repo, so I can't check it for now either.
https://github.com/dart-lang/intl/tags

I've added an entry to the changelog, but I think there might still be issues with flutter_localization from the issues you linked.

Indeed, https://github.com/flutter/flutter/blob/07c47dcc3d55be89cb3dbb3d10d5d65ed455c4bd/packages/flutter_localizations/pubspec.yaml#L11
They pinned the version, so if I bump, its incompatible as well.
Not sure what's the best approach here now.
@ueman ideas?
Instead of using ^0.18.0, we could do any, but that could lead to new problems in the future as well due to breaking changes, but it solves the problem right now.

I don't think setting any would be the solution here, would definitely cause more issues later on. Maybe the solution is to simply wait for Flutter to fix things on their sides.

As said, I would suggest

Suggested change

intl: ^0.18.0

intl: '>=0.17.0 <0.19.0'

It's better than the current situation and even ^0.18.0 wouldn't be compatible with 0.19.0 as demonstrated by this PR. So, I think the suggestion is the way to go. It's a bit better than any, but, granted, only a bit.

In the future, intl should probably be vendored or just removed to avoid this problem. There's just one usage anyway, I believe.

Does disallowing 0.17.0 break usages on older Flutter versions?

Does disallowing 0.17.0 break usages on older Flutter versions?

I believe so based on the fact that we're required to make this current change.

Yeah IMO the bug is not here, let's see if they act quickly on dart-lang/pub#3747 otherwise we push @ueman suggested fix for now.
Vendoring the class would work too but I'd like to avoid it for now.

marandaneto · 2023-01-12T12:37:31Z

@zeshuaro can you add an entry to the changelog? Thanks!

zeshuaro · 2023-01-13T06:37:38Z

I've added an entry to the changelog, but I think there might still be issues with flutter_localization from the issues you linked.

marandaneto · 2023-01-25T12:58:59Z

Closed in favor of #1247
Thank you all!

Update dependency intl to ^0.18.0

6338d0e

zeshuaro requested review from marandaneto, brustolin and krystofwoldrich as code owners December 21, 2022 11:31

ueman reviewed Dec 21, 2022

View reviewed changes

marandaneto mentioned this pull request Dec 23, 2022

Upgrade intl dependency #1206

Closed

zeshuaro added 2 commits January 13, 2023 17:34

Update changelog for bumping intl to ^0.18.0

5aeb4d9

Merge branch 'main' into patch-1

9680c32

fix changelog

b47429d

This was referenced Jan 24, 2023

The constraint ^0.17.0 on intl does not support the stable version 0.18.0 dart-lang/pub#3747

Closed

Vendor intl #1241

Closed

intl is now more version permissive #1247

Merged

marandaneto closed this Jan 25, 2023

zeshuaro deleted the patch-1 branch January 26, 2023 01:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependency `intl` to ^0.18.0 #1202

Update dependency `intl` to ^0.18.0 #1202

zeshuaro commented Dec 21, 2022 •

edited

Loading

marandaneto commented Dec 21, 2022

zeshuaro commented Dec 21, 2022

codecov-commenter commented Dec 21, 2022 •

edited by codecov bot

Loading

ueman Dec 21, 2022

zeshuaro Dec 21, 2022

marandaneto Dec 21, 2022

marandaneto Dec 21, 2022

marandaneto Dec 21, 2022 •

edited

Loading

marandaneto Jan 13, 2023

zeshuaro Jan 14, 2023

ueman Jan 14, 2023 •

edited

Loading

zeshuaro Jan 16, 2023

marandaneto Jan 24, 2023

marandaneto commented Jan 12, 2023

zeshuaro commented Jan 13, 2023

marandaneto commented Jan 25, 2023

Update dependency intl to ^0.18.0 #1202

Update dependency intl to ^0.18.0 #1202

Conversation

zeshuaro commented Dec 21, 2022 • edited Loading

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

marandaneto commented Dec 21, 2022

zeshuaro commented Dec 21, 2022

codecov-commenter commented Dec 21, 2022 • edited by codecov bot Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marandaneto Dec 21, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ueman Jan 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marandaneto commented Jan 12, 2023

zeshuaro commented Jan 13, 2023

marandaneto commented Jan 25, 2023

Update dependency `intl` to ^0.18.0 #1202

Update dependency `intl` to ^0.18.0 #1202

zeshuaro commented Dec 21, 2022 •

edited

Loading

codecov-commenter commented Dec 21, 2022 •

edited by codecov bot

Loading

marandaneto Dec 21, 2022 •

edited

Loading

ueman Jan 14, 2023 •

edited

Loading