Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc links to sidebar on pub.dev #1307

Merged
merged 8 commits into from
Mar 3, 2023
Merged

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Mar 2, 2023

📜 Description

With this change, the links to the Sentry docs are added to the sidebar on pub.dev

#skip-changelog

💚 How did you test it?

Just doc changes

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@@ -6,6 +6,7 @@ description: >
homepage: https://docs.sentry.io/platforms/dart/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the homepage already linked to the docs, I never happend to click on it because I assumed it leads me to sentry.io instead of the docs.

dio/pubspec.yaml Outdated Show resolved Hide resolved
file/pubspec.yaml Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor

Nice, we can add the one for logging as well.
https://docs.sentry.io/platforms/dart/configuration/integrations/logging/

Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@ueman
Copy link
Collaborator Author

ueman commented Mar 2, 2023

https://docs.sentry.io/platforms/dart/configuration/integrations/logging/

I already wondered why there's nothing for logging. Must have missed it

@ueman ueman marked this pull request as ready for review March 2, 2023 12:58
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fe4aa56) 89.82% compared to head (26e2a28) 89.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files         155      155           
  Lines        5063     5063           
=======================================
  Hits         4548     4548           
  Misses        515      515           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ueman
Copy link
Collaborator Author

ueman commented Mar 2, 2023

The failing job is unrelated, since I haven't changed any actual code.

dio/pubspec.yaml Outdated Show resolved Hide resolved
file/pubspec.yaml Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor

The failing job is unrelated, since I haven't changed any actual code.

just flakiness for the integration test, and the other one was lining, fixed it now.

@marandaneto marandaneto enabled auto-merge (squash) March 3, 2023 07:45
@marandaneto marandaneto merged commit f96ca24 into getsentry:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants