-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include and set ProGuard uuid in Flutter Options #1312
Include and set ProGuard uuid in Flutter Options #1312
Conversation
@Wcisang you could technically set it directly into the Manifest file on Android. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
==========================================
- Coverage 90.03% 89.83% -0.21%
==========================================
Files 110 155 +45
Lines 3483 5064 +1581
==========================================
+ Hits 3136 4549 +1413
- Misses 347 515 +168
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@marandaneto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Wcisang
Before merging, please add an entry to our changelog :)
Done! |
I can cut a release once CI is happy, just fixed a detekt issue. |
📜 Description
I just added a proGuardUuid property to the Options and passed it to Sentry's android native initialization.
💡 Motivation and Context
Due to the flutter SDK not having support to configure the proguard uuid, it is necessary to perform a large workaround to perform this action.
So this simple modification already makes it possible for Flutter apps to configure the proguard uuid at runtime.
💚 How did you test it?
created unit tests for testing defaults and custom values
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps