Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android breadcrumbs on web #1378

Merged
merged 12 commits into from
Apr 11, 2023
Merged

Fix Android breadcrumbs on web #1378

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
45855a8
Fix Android breadcrumbs on web
mnordine Apr 3, 2023
4c408c5
Remove extra line that made it in commit by mistake
mnordine Apr 3, 2023
64fe2b0
Dart format
mnordine Apr 3, 2023
40e8f6c
Add fix to changelog
mnordine Apr 3, 2023
676ab31
Update CHANGELOG.md
marandaneto Apr 6, 2023
096ed60
Update CHANGELOG.md
mnordine Apr 6, 2023
e6c9037
Merge remote-tracking branch 'upstream/main' into android-web-breadcr…
mnordine Apr 7, 2023
be07e29
Do not remove breadcrumbs on web
mnordine Apr 7, 2023
37a07ed
Merge remote-tracking branch 'origin/android-web-breadcrumbs-fix' int…
mnordine Apr 7, 2023
da773c3
Add test for breadcrumbs with Android web client
mnordine Apr 8, 2023
a090436
Run dart format
mnordine Apr 8, 2023
076dc60
fix changelog
marandaneto Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

### Fixes

- Fix breadcrumbs not being sent on Android web ([#1378](https://github.com/getsentry/sentry-dart/pull/1378))

### Fixes

mnordine marked this conversation as resolved.
Show resolved Hide resolved
- Fix Dart web builds breaking due to `dart:io` imports when using `SentryIsolate` or `SentryIsolateExtension` ([#1371](https://github.com/getsentry/sentry-dart/pull/1371))
- When using `SentryIsolate` or `SentryIsolateExtension`, import `sentry_io.dart`.

Expand Down
3 changes: 2 additions & 1 deletion dart/lib/src/sentry_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ class SentryClient {
return _sentryId;
}

if (_options.platformChecker.platform.isAndroid &&
if (!_options.platformChecker.isWeb &&
_options.platformChecker.platform.isAndroid &&
marandaneto marked this conversation as resolved.
Show resolved Hide resolved
_options.enableScopeSync) {
/*
We do this to avoid duplicate breadcrumbs on Android as sentry-android applies the breadcrumbs
Expand Down