Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SDK name of Sentry Native for Flutter #1468

Merged
merged 3 commits into from
May 23, 2023
Merged

Change SDK name of Sentry Native for Flutter #1468

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02e696e
Update native sdk names
denrase May 22, 2023
216d1f3
fix name
marandaneto May 23, 2023
54b2a59
Merge branch 'main' into enha/set-sdk-name
marandaneto May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
private var autoPerformanceTracingEnabled = false

private val flutterSdk = "sentry.dart.flutter"
private val androidSdk = "sentry.java.android.flutter"
private val androidSdk = "sentry.native.android.flutter"
marandaneto marked this conversation as resolved.
Show resolved Hide resolved
private val nativeSdk = "sentry.native.android"

override fun onAttachedToEngine(flutterPluginBinding: FlutterPlugin.FlutterPluginBinding) {
Expand Down
2 changes: 1 addition & 1 deletion flutter/ios/Classes/SentryFlutterPluginApple.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import AppKit
// swiftlint:disable:next type_body_length
public class SentryFlutterPluginApple: NSObject, FlutterPlugin {

private static let nativeClientName = "sentry.cocoa.flutter"
private static let nativeClientName = "sentry.native.cocoa.flutter"
marandaneto marked this conversation as resolved.
Show resolved Hide resolved

// The Cocoa SDK is init. after the notification didBecomeActiveNotification is registered.
// We need to be able to receive this notification and start a session when the SDK is fully operational.
Expand Down