Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Min Version Test #1537

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Web Min Version Test #1537

merged 5 commits into from
Jul 11, 2023

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jul 4, 2023

#skip-changelog

📜 Description

Build min version web target.

💡 Motivation and Context

Closes #1464

💚 How did you test it?

Run CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.73 ⚠️

Comparison is base (84a3369) 90.98% compared to head (92590ae) 90.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
- Coverage   90.98%   90.25%   -0.73%     
==========================================
  Files          61      181     +120     
  Lines        2019     5779    +3760     
==========================================
+ Hits         1837     5216    +3379     
- Misses        182      563     +381     

see 120 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denrase denrase marked this pull request as ready for review July 10, 2023 11:00
@denrase denrase merged commit 5bd9613 into main Jul 11, 2023
@denrase denrase deleted the enha/web-min-version-test branch July 11, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile web version in min_version_test CI
2 participants