Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): report total frames, frame delay, slow & frozen frames #2106

Merged
merged 67 commits into from
Jun 25, 2024
+779 −9

Add comment why we don't use CADisplayLink in macos

736bafc
Select commit
Loading
Failed to load commit list.
Merged

feat(performance): report total frames, frame delay, slow & frozen frames #2106

Add comment why we don't use CADisplayLink in macos
736bafc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 25, 2024 in 0s

88.41% (-0.24%) compared to 7e7f0b1

View this Pull Request on Codecov

88.41% (-0.24%) compared to 7e7f0b1

Details

Codecov Report

Attention: Patch coverage is 74.40000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (7e7f0b1) to head (736bafc).

Files Patch % Lines
flutter/lib/src/span_frame_metrics_collector.dart 86.31% 13 Missing ⚠️
flutter/lib/src/frame_callback_handler.dart 0.00% 6 Missing ⚠️
dart/lib/src/protocol/sentry_span.dart 54.54% 5 Missing ⚠️
dart/lib/src/sentry_tracer.dart 33.33% 4 Missing ⚠️
dart/lib/src/sentry_options.dart 50.00% 2 Missing ⚠️
flutter/lib/src/native/sentry_native_channel.dart 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2106      +/-   ##
==========================================
- Coverage   88.64%   88.41%   -0.24%     
==========================================
  Files         223      224       +1     
  Lines        7583     7705     +122     
==========================================
+ Hits         6722     6812      +90     
- Misses        861      893      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov