add webview and video widgets to the sample app #2355
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Trying out if we can mask webviews & videos. Because webviews & video components are not part of the flutter core framework (instead, they're separate 3rd party plugins), we cannot checks by widget type. We could, in theory, check the name as a string but that would not work in obfuscated apps and would be counterproductive because then users would see the widgets obfuscated while testing locally (in debug builds) while they would be clearly visible when deployed in release mode (and obfuscated).
Therefore, I'd say we do not obfuscate these by default and let users do so with custom masking introduced by #2324
💡 Motivation and Context
Part of #1193 (comment)
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps